Repository navigation
K13.8: bad ids and cookies get 404/401, not 500 - #142
Merged
Merged
Conversation
A non-UUID funding id reached the uuid column and a malformed cookie made cookie decoding throw, so both returned 500. Closes #134
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix 7 from the pre-launch review (crashes).
Problem: a non-UUID id in
/api/fund/:id/…went straight to a uuid column and Postgres threw (500). A malformedstack_sessioncookie madedecodeURIComponentthrow, so that browser got a 500 on every API call.Fix:
uuidParam()turns a non-UUID id into 404;readCookietreats an undecodable cookie as absent (signed out, 401).Tests: 2 new, both confirmed failing before the fix. 150 total.
Docs: README status, ARCHITECTURE §4.1, ROADMAP.
Closes #134