feat: replace custom brand mark with design-system Logo (ui#29 wave 2) - #10
Merged
Conversation
Picks up the serif heading typography (Fraunces h1–h3), kbd mono, and the semantic state tokens from the design-system brand refresh. Refs #29 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
dock defined its own ✦-style brand glyph (
BrandMarkinsrc/components/TopBar.tsx) paired with a hand-rolled<span>Mind Dock</span>wordmark. This swaps that custom lockup for the design-system<Logo />(ui 0.7.0), so dock now renders the real shared weave mark + the "Mind" wordmark in the brand serif (Fraunces).dock is the unified Mind hub, so the lockup reads "Mind" —
<Logo />with nolabel(defaults to the active theme's label).BrandMarkremoved entirely (rather than kept as a wrapper): both call sites rendered<BrandMark />+ a separate<span>wordmark, so keepingBrandMarkas a<Logo />wrapper would have produced a doubled mark/wordmark ("Mind Mind Dock"). Replacing the whole lockup with a single<Logo />is cleaner and avoids the duplication.<span>Mind Dock</span>wordmark spans were removed at both sites (the<Logo />wordmark replaces them; hub now reads "Mind").BrandMark'ssizeprop was not load-bearing —<Logo />carries its own intrinsic sizing and the wordmark replaces the styled text span, so no size mapping was needed.Call sites touched
src/components/TopBar.tsx—TopBarmasthead lockup (the<Link href="/dock">); removed theBrandMarkexport, addedLogoto the@mind-studio/uiimport.src/app/page.tsx— landing-page header lockup; dropped theBrandMarkimport, addedimport { Logo } from "@mind-studio/ui".Test plan
npm run typecheck✓npm run lint✓ (exit 0; only pre-existing warnings in untouched files)npm run test✓ (no test files, passWithNoTests)npm run build✓ (Next.js 16 production build, all routes generated)Wave 2 fan-out (Tier 3, dock special case), pattern from drive#17.
🤖 Generated with Claude Code