Skip to content

IN-1786 - #81

Closed
tim-rix wants to merge 1 commit into
mainfrom
IN-1761
Closed

tim-rix wants to merge 1 commit into
mainfrom
IN-1761

Conversation

@tim-rix

@tim-rix tim-rix commented Sep 1, 2026 •

Copy link
Copy Markdown
Contributor

Move the Configure AWS Credentials step to before the Run pre-build steps in the ecr-multi-arch-deploy_* scripts

Why these changes are being introduced

A bug was discovered in alma-patronload that prevented access to shared files in the pre-build sequence.

How this addresses that need

Moved the Configure AWS credentials step to before the Run pre-build steps section in

  • ecr-multi-arch-deploy-dev.yml
  • ecr-multi-arch-stage.yml
  • Prod doesn't need an update because it copies the stage version to Prod

Side effects of this change

No other changes

Relevant ticket(s)

IN-1786

Move teh Configure AWS Credentials step to before the
Run pre-build steps in the ecr-multi-arch-deploy_* scripts
@tim-rix
tim-rix requested a review from a team as a code owner September 1, 2026 14:28
@cabutlermit

Copy link
Copy Markdown
Contributor

@tim-rix did you test the updated workflows by running the dev-build workflows in any appliction repositories? especially the patronload repository? If so, can you link to those runs?

@cabutlermit cabutlermit self-assigned this Sep 1, 2026
@tim-rix

tim-rix commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

I'm wondering just how I would test these changes. The patronload repository can't pull the new code until the PR has been merged (right?) so it feels like a chicken/egg scenario.

@cabutlermit

Copy link
Copy Markdown
Contributor

I'm wondering just how I would test these changes. The patronload repository can't pull the new code until the PR has been merged (right?) so it feels like a chicken/egg scenario.

You are working on this PR because there is a PR on alma-patronload from @ehanson8 to update a number of things, including the three workflows. You should work with Eric to add a (temporary) commit to that feature branch / pull request to update the dev-build.yml workflow to reference this branch (in-1761) instead of the main branch.

That is, change Line 17 in that workflow file from

    uses: mitlibraries/.github/.github/workflows/ecr-multi-arch-deploy-dev.yml@main

to

    uses: mitlibraries/.github/.github/workflows/ecr-multi-arch-deploy-dev.yml@in-1761

When that commit gets pushed to GitHub, it should automatically run the new workflow since it's part of an open PR to the main branch.

@cabutlermit

Copy link
Copy Markdown
Contributor

@tim-rix I also just realized that your feature branch name on this repo is in-1761 but your PR name is IN-1786 which is a little confusing...

@tim-rix

tim-rix commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

The feature branch name is a typo. To fix (rename) it will close this PR so look for a new PR. I'll tag Eric on the new PR so he can test the changes in Dev

@tim-rix tim-rix closed this Sep 1, 2026
@tim-rix

tim-rix commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

Renaming the feature branch for continuity

@tim-rix
tim-rix deleted the IN-1761 branch September 1, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants