IN-1786

[tim-rix]

Move the Configure AWS Credentials step to before the Run pre-build steps in the ecr-multi-arch-deploy_* scripts

Why these changes are being introduced

A bug was discovered in alma-patronload that prevented access to shared files in the pre-build sequence.

How this addresses that need

Moved the Configure AWS credentials step to before the Run pre-build steps section in

• ecr-multi-arch-deploy-dev.yml
• ecr-multi-arch-stage.yml
• Prod doesn't need an update because it copies the stage version to Prod

Side effects of this change

No other changes

Relevant ticket(s)

IN-1786

[tim-rix]

@ehanson8 I tagged you as this PR should fix something you're waiting on in the alma-patronload repo.

Christopher said we should add a (temporary) commit to that MITLibraries/alma-patronload#158 to update the dev-build.yml workflow to reference this branch (IN-1786) instead of the main branch.
That is, change Line 17 in that workflow file from
uses: [mitlibraries/.github/.github/workflows/ecr-multi-arch-deploy-dev.yml@main]
to
uses: [mitlibraries/.github/.github/workflows/ecr-multi-arch-deploy-dev.yml@in-1786]

When that commit gets pushed to GitHub, it should automatically run the new workflow since it's part of an open PR to the main branch. Do you prefer I make this (temporary) change or would you like to?

[ehanson8]

mitlibraries/.github/.github/workflows/ecr-multi-arch-deploy-dev.yml@in-1786

I can take care of this and I'll reach out if anything goes haywire, thanks for your work on this!

[ehanson8]

Success!

[ehanson8]

Spoke too soon, CI passed but dev-build didn't run anything https://github.com/MITLibraries/alma-patronload/actions/runs/33549429731

[cabutlermit]

Spoke too soon, CI passed but dev-build didn't run anything https://github.com/MITLibraries/alma-patronload/actions/runs/33549429731

@ehanson8 this is the error message for the failed dev-build run:

Invalid workflow file: .github/workflows/dev-build.yml#L17
error parsing called workflow
".github/workflows/dev-build.yml"
-> "mitlibraries/.github/.github/workflows/ecr-multi-arch-deploy-dev.yml@in-1786"
: failed to fetch workflow: reference to workflow should be either a valid branch, tag, or commit

I think that the issue is that the name of the feature branch here is IN-1786, but when you updated the dev-build workflow in the other repository you used in-1786. I'm 99% sure that branch names are case-sensitive...

[ehanson8]

Spoke too soon, CI passed but dev-build didn't run anything https://github.com/MITLibraries/alma-patronload/actions/runs/33549429731

@ehanson8 this is the error message for the failed dev-build run:

Invalid workflow file: .github/workflows/dev-build.yml#L17
error parsing called workflow
".github/workflows/dev-build.yml"
-> "mitlibraries/.github/.github/workflows/ecr-multi-arch-deploy-dev.yml@in-1786"
: failed to fetch workflow: reference to workflow should be either a valid branch, tag, or commit

I think that the issue is that the name of the feature branch here is IN-1786, but when you updated the dev-build workflow in the other repository you used in-1786. I'm 99% sure that branch names are case-sensitive...

Absolutely my bad, apologies! All good now