Read new env vars from updated DSpace credentials secrets - #269
Merged
Merged
Conversation
jonavellecuerdo
force-pushed
the
DSO-126-read-new-env-vars-for-new-secrets
branch
from
September 22, 2026 13:27
f00be47 to
472f409
Compare
jonavellecuerdo
marked this pull request as ready for review
September 22, 2026 13:31
ghukill
approved these changes
Sep 22, 2026
ghukill
left a comment
ghukill
left a comment
Contributor
There was a problem hiding this comment.
I've requested a change, but it's purely linting-esque. So my review is an approval and the change is ultimately optional; approval stands either way.
Looks good!
Comment on lines
+173
to
+182
| def get_dspace_credentials(self, submission_system: Literal["IR-8", "DDC-8"]) -> dict: | ||
| """Get parsed dspace credentials.""" | ||
| if submission_system == "IR-8": | ||
| return self.openschol_rw_api_credentials_json | ||
| if submission_system == "DDC-8": | ||
| return self.digcoll_rw_api_credentials_json | ||
|
|
||
| raise ValueError( | ||
| f"'submission_system' should be one of ['IR-8', 'DDC-8'], got '{submission_system}'" # noqa: E501 | ||
| ) |
Why these changes are being introduced: * The old DSpace6 instances have been fully retired, and we are only dealing with credential sets for MIT Open Scholarship (dspace.mit.edu) and Digital Collections (dome.mit.edu). This allowed us the opportunity to clean up and rework storage and access to DSpace credentials used by DSO and other apps interacting with DSpace. How this addresses that need: * Config reads new DSpace API credentials env vars * Config includes method to get correct dspace credentials based on submission system (i.e., one of ["IR-8", "DDC-8"]) * Standardize `Workflow.submission_system` class attribute * Digitized theses workflow updates `DSpaceClient` with access headers (if set) Side effects of this change: * None Relevant ticket(s): * https://mitlibraries.atlassian.net/browse/DSO-126 * https://mitlibraries.atlassian.net/browse/DSO-131
jonavellecuerdo
force-pushed
the
DSO-126-read-new-env-vars-for-new-secrets
branch
from
September 22, 2026 13:58
472f409 to
fba73bb
Compare
ehanson8
approved these changes
Sep 22, 2026
|
|
||
| workflow_name: str = "archivesspace" | ||
| submission_system: str = "Dome" | ||
| submission_system: Literal["IR-8", "DDC-8"] = "DDC-8" |
jonavellecuerdo
deleted the
DSO-126-read-new-env-vars-for-new-secrets
branch
September 22, 2026 14:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose and background context
The old DSpace6 instances have been fully retired, and we are only dealing with credential sets for MIT Open Scholarship (dspace.mit.edu) and Digital Collections (dome.mit.edu). This allowed us the opportunity to clean up and rework storage and access to DSpace credentials used by DSO and other apps interacting with DSpace.
How can a reviewer manually see the effects of these changes?
Note the following logs:
Includes new or updated dependencies?
NO
Changes expectations for external applications?
NO
What are the relevant tickets?
Code review