Clean up block implementation - #222
Draft
matt-bernhardt wants to merge 11 commits into
Draft
Conversation
These packages are not needed in this way - need to work out how to specify them. Declare WordPress packages as dev dependencies
Use of ' instead of ' causes complaints by the linter...
In some cases, we remove the boilerplate import because there's no opportunity to use it (the rendering is handled via PHP). In other cases, we properly route useBlockProps.save() into markup as the application expects.
The featured collection never passes any output through a translation function, so we do not need to import it in the first place.
Re-run build
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is pretty speculative at the moment, and is aimed at resolving conditions in the block definitions that were either unused details of the boilerplate or are otherwise being flagged by our linting and analysis tools.