WEB-2466: Update to hero image on homepage - #223
Conversation
There was a problem hiding this comment.
Found 1 issue across 1 rule.
Reviewed by AccessLint, which checks every pull request for accessibility issues.
|
|
||
| </div> | ||
| <span class="hero-image-credit">from the <a href="https://archivesspace.mit.edu/repositories/2/resources/603">Harold E. Edgerton papers</a></span> | ||
| <span class="hero-image-credit">from the <a href="https://archivesspace.mit.edu/repositories/2/resources/244">Muriel Cooper personal archives</a></span> |
There was a problem hiding this comment.
WCAG 4.1.2: Focusable element inside a "img" role whose children are presentational.
Elements with a role that makes children presentational must not contain focusable content.
Details
Roles like button, checkbox, img, tab, and others make their children presentational — hidden from assistive technologies. If those children are focusable, keyboard users can reach elements that screen reader users cannot perceive. Move focusable content outside the parent or remove the focusability.
There was a problem hiding this comment.
Fixed by moving image into a separate div with the img role.
There was a problem hiding this comment.
Found 1 issue across 1 rule.
Reviewed by AccessLint, which checks every pull request for accessibility issues.
|
|
||
| </div> | ||
| <span class="hero-image-credit">from the <a href="https://archivesspace.mit.edu/repositories/2/resources/603">Harold E. Edgerton papers</a></span> | ||
| <span class="hero-image-credit">from the <a href="https://archivesspace.mit.edu/repositories/2/resources/244">Muriel Cooper personal archives</a></span> |
There was a problem hiding this comment.
WCAG 4.1.2: Focusable element inside a "img" role whose children are presentational.
Elements with a role that makes children presentational must not contain focusable content.
Details
Roles like button, checkbox, img, tab, and others make their children presentational — hidden from assistive technologies. If those children are focusable, keyboard users can reach elements that screen reader users cannot perceive. Move focusable content outside the parent or remove the focusability.
matt-bernhardt
left a comment
There was a problem hiding this comment.
Looks good to me - it seems okay running locally, although in fairness I haven't pushed on it super hard. The new content looks nice, and that image is pretty awesome.
![]()
Developer
This work rotates to a new hero image and citation link.
Stylesheets
string incremented.
Secrets
Documentation
Accessibility
our guide and
all issues introduced by these changes have been resolved or opened as new
issues (link to those issues in the Pull Request details above)
Stakeholder approval
Dependencies
YES | NO dependencies are updated
Code Reviewer
(not just this pull request message)