Skip to content

[tests] Generalize alpaka tests over backends and implement the hip build #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
harz05 wants to merge 1 commit into
base: gpu/alpaka
Choose a base branch
from
Draft

[tests] Generalize alpaka tests over backends and implement the hip build #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
154 changes: 101 additions & 53 deletions test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,8 @@ ROOTTEST_ADD_TEST(
if (ENABLE_ALPAKA_TESTS)

string(TOLOWER "${ALPAKA_BACKEND}" _alpaka_backend)
if (NOT _alpaka_backend IN_LIST ALPAKA_BACKEND)
set(_alpaka_known_backends cuda cpu hip sycl)
if (NOT _alpaka_backend IN_LIST _alpaka_known_backends)
message(FATAL_ERROR "Unsupported ALPAKA_BACKEND=${ALPAKA_BACKEND}")
endif()

Expand Down Expand Up @@ -134,69 +135,91 @@ if (ENABLE_ALPAKA_TESTS)
)

##########################################################################
# CUDA backend
# Backend selection
#
# The test sources are backend-agnostic (see alpaka/TestAlpakaCommon.h),
# only the toolchain, flags and libraries differ per backend.
##########################################################################
if (_alpaka_backend STREQUAL "cuda")
set(ALPAKA_TEST_SOURCES
alpaka/TestAlpakaLinear.cxx
alpaka/TestAlpakaConv.cxx
alpaka/TestAlpakaNormalization.cxx
alpaka/TestAlpakaElementwiseUnary.cxx
alpaka/TestAlpakaElementwiseBinaryLogic.cxx
alpaka/TestAlpakaReduce.cxx
alpaka/TestAlpakaShapeIndexing.cxx
alpaka/TestAlpakaGNN.cxx
alpaka/TestAlpakaPool.cxx
alpaka/TestAlpakaLowRank.cxx
alpaka/TestAlpakaKernelOnly.cxx
alpaka/TestAlpakaNormReduction.cxx
alpaka/TestAlpakaSequenceOps.cxx
)

if (_alpaka_backend STREQUAL "cuda")
message(STATUS "Enabling Alpaka CUDA tests")

enable_language(CUDA)
find_package(CUDAToolkit REQUIRED)
set(ALPAKA_TEST_TARGET TestCustomModelsFromONNXForAlpakaCuda)
set_source_files_properties(${ALPAKA_TEST_SOURCES} PROPERTIES LANGUAGE CUDA)
elseif (_alpaka_backend STREQUAL "hip")
message(STATUS "Enabling Alpaka HIP tests")
enable_language(HIP)
set(ROCM_BASE "/opt/rocm" CACHE PATH "ROCm installation prefix")
set(ALPAKA_TEST_TARGET TestCustomModelsFromONNXForAlpakaHip)
set_source_files_properties(${ALPAKA_TEST_SOURCES} PROPERTIES LANGUAGE HIP)
elseif (_alpaka_backend STREQUAL "sycl")
message(FATAL_ERROR "ALPAKA_BACKEND=sycl is not implemented yet.")
elseif (_alpaka_backend STREQUAL "cpu")
message(FATAL_ERROR "ALPAKA_BACKEND=cpu is not implemented yet.")
endif()

set(ALPAKA_CUDA_TEST_SOURCES
alpaka/TestAlpakaLinear.cxx
alpaka/TestAlpakaConv.cxx
alpaka/TestAlpakaNormalization.cxx
alpaka/TestAlpakaElementwiseUnary.cxx
alpaka/TestAlpakaElementwiseBinaryLogic.cxx
alpaka/TestAlpakaReduce.cxx
alpaka/TestAlpakaShapeIndexing.cxx
alpaka/TestAlpakaGNN.cxx
alpaka/TestAlpakaPool.cxx
alpaka/TestAlpakaLowRank.cxx
alpaka/TestAlpakaKernelOnly.cxx
alpaka/TestAlpakaNormReduction.cxx
alpaka/TestAlpakaSequenceOps.cxx
)
ROOTTEST_GENERATE_EXECUTABLE(
${ALPAKA_TEST_TARGET}
${ALPAKA_TEST_SOURCES}
LIBRARIES SOFIE_core GTest::gtest GTest::gtest_main
FIXTURES_REQUIRED sofie-compile-models-onnx-alpaka;sofie-lowrank-emit
FIXTURES_SETUP sofie-test-models-onnx-alpaka-build
)

set_source_files_properties(
${ALPAKA_CUDA_TEST_SOURCES}
PROPERTIES LANGUAGE CUDA
)
target_include_directories(
${ALPAKA_TEST_TARGET} PRIVATE
${CMAKE_CURRENT_BINARY_DIR}
${alpaka_SOURCE_DIR}/include
${sofieblas_SOURCE_DIR}/include
${CMAKE_CURRENT_SOURCE_DIR}
)

ROOTTEST_GENERATE_EXECUTABLE(
TestCustomModelsFromONNXForAlpakaCuda
${ALPAKA_CUDA_TEST_SOURCES}
LIBRARIES SOFIE_core GTest::gtest GTest::gtest_main
FIXTURES_REQUIRED sofie-compile-models-onnx-alpaka;sofie-lowrank-emit
FIXTURES_SETUP sofie-test-models-onnx-alpaka-build
)
target_compile_definitions(
${ALPAKA_TEST_TARGET} PRIVATE
ALPAKA_HAS_STD_ATOMIC_REF
)

##########################################################################
# Backend-specific flags and libraries
##########################################################################
if (_alpaka_backend STREQUAL "cuda")

target_include_directories(
TestCustomModelsFromONNXForAlpakaCuda PRIVATE
${CMAKE_CURRENT_BINARY_DIR}
${alpaka_SOURCE_DIR}/include
${sofieblas_SOURCE_DIR}/include
${ALPAKA_TEST_TARGET} PRIVATE
${CUDAToolkit_INCLUDE_DIRS}
${CMAKE_CURRENT_SOURCE_DIR}
)

set_target_properties(
TestCustomModelsFromONNXForAlpakaCuda
${ALPAKA_TEST_TARGET}
PROPERTIES
CUDA_SEPARABLE_COMPILATION OFF
CUDA_STANDARD 20
CUDA_STANDARD_REQUIRED ON
)

target_compile_definitions(
TestCustomModelsFromONNXForAlpakaCuda PRIVATE
${ALPAKA_TEST_TARGET} PRIVATE
ALPAKA_ACC_GPU_CUDA_ENABLED
ALPAKA_HAS_STD_ATOMIC_REF
)

target_compile_options(
TestCustomModelsFromONNXForAlpakaCuda PRIVATE
${ALPAKA_TEST_TARGET} PRIVATE
$<$<COMPILE_LANGUAGE:CUDA>:
--extended-lambda
--expt-relaxed-constexpr
Expand All @@ -220,25 +243,50 @@ if (ENABLE_ALPAKA_TESTS)

# ROOT-compatible: plain signature only
target_link_libraries(
TestCustomModelsFromONNXForAlpakaCuda
${ALPAKA_TEST_TARGET}
CUDA::cudart
CUDA::cublas
CUDA::cublasLt
)

ROOTTEST_ADD_TEST(
TestCustomModelsFromONNXForAlpakaCuda
EXEC ./TestCustomModelsFromONNXForAlpakaCuda
FIXTURES_REQUIRED sofie-compile-models-onnx-alpaka;sofie-lowrank-emit;sofie-test-models-onnx-alpaka-build
elseif (_alpaka_backend STREQUAL "hip")

set_target_properties(
${ALPAKA_TEST_TARGET}
PROPERTIES
HIP_STANDARD 20
HIP_STANDARD_REQUIRED ON
)

elseif (_alpaka_backend STREQUAL "hip")
message(FATAL_ERROR
"ALPAKA_BACKEND=hip is not implemented yet (AMD GPU support is planned, "
"see test/alpaka/). Use ALPAKA_BACKEND=cuda for now.")
elseif (_alpaka_backend STREQUAL "sycl")
message(FATAL_ERROR "ALPAKA_BACKEND=sycl is not implemented yet.")
elseif (_alpaka_backend STREQUAL "cpu")
message(FATAL_ERROR "ALPAKA_BACKEND=cpu is not implemented yet.")
endif() # cuda backend
target_compile_definitions(
${ALPAKA_TEST_TARGET} PRIVATE
ALPAKA_ACC_GPU_HIP_ENABLED
)

target_compile_options(
${ALPAKA_TEST_TARGET} PRIVATE
-O2
-g
-fPIC
-pthread
)

target_include_directories(${ALPAKA_TEST_TARGET} PRIVATE ${ROCM_BASE}/include)
target_link_directories(${ALPAKA_TEST_TARGET} PRIVATE ${ROCM_BASE}/lib)

# ROOT-compatible: plain signature only
target_link_libraries(
${ALPAKA_TEST_TARGET}
hipblaslt
hipblas
amdhip64
)

endif()

ROOTTEST_ADD_TEST(
${ALPAKA_TEST_TARGET}
EXEC ./${ALPAKA_TEST_TARGET}
FIXTURES_REQUIRED sofie-compile-models-onnx-alpaka;sofie-lowrank-emit;sofie-test-models-onnx-alpaka-build
)
endif() # ENABLE_ALPAKA_TESTS
36 changes: 24 additions & 12 deletions test/alpaka/TestAlpakaCommon.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@
#include <numeric>
#include <cstddef>
#include <alpaka/alpaka.hpp>
#include <cuda_runtime.h>
#include <nvml.h>
#include "gtest/gtest.h"

constexpr float DEFAULT_TOLERANCE = 1e-3f;
Expand All @@ -14,16 +12,30 @@ using Idx = std::size_t;
using Dim = alpaka::DimInt<1>;
using Ext1D = alpaka::Vec<Dim, Idx>;

/* The backend under test is selected from the accelerator macro the build
defines, so the same test sources compile for every alpaka backend. */
#if defined(ALPAKA_ACC_GPU_CUDA_ENABLED)
using TestTag = alpaka::TagGpuCudaRt;
#elif defined(ALPAKA_ACC_GPU_HIP_ENABLED)
using TestTag = alpaka::TagGpuHipRt;
#else
#error "No alpaka backend enabled for the SOFIE tests"
#endif

using TestAcc = alpaka::TagToAcc<TestTag, Dim, Idx>;
using TestDev = alpaka::Dev<TestAcc>;
using TestQueue = alpaka::Queue<TestDev, alpaka::NonBlocking>;

class SofieAlpakaTest : public ::testing::Test {
protected:
// Shared devices and platforms
alpaka::PlatformCpu hostPlatform;
alpaka::DevCpu host;
alpaka::PlatformCudaRt platform;
alpaka::DevCudaRt device;
alpaka::Queue<alpaka::DevCudaRt, alpaka::NonBlocking> queue;
alpaka::Platform<TestAcc> platform;
TestDev device;
TestQueue queue;

SofieAlpakaTest()
SofieAlpakaTest()
: hostPlatform{}
, host(alpaka::getDevByIdx(hostPlatform, 0u))
, platform{}
Expand All @@ -33,25 +45,25 @@ class SofieAlpakaTest : public ::testing::Test {
}

void SetUp() override {
cudaDeviceSynchronize();
alpaka::wait(device);
}

void TearDown() override {
alpaka::wait(queue);
cudaDeviceSynchronize();
alpaka::wait(device);
}

~SofieAlpakaTest() override {
cudaDeviceSynchronize();
alpaka::wait(device);
}
};

// Helper: copy a host C-array into an Alpaka host buffer then to device.
template <typename T>
static alpaka::Buf<alpaka::DevCudaRt, T, Dim, Idx>
static alpaka::Buf<TestDev, T, Dim, Idx>
makeDeviceBuf(alpaka::DevCpu const& host,
alpaka::DevCudaRt const& device,
alpaka::Queue<alpaka::DevCudaRt, alpaka::NonBlocking>& queue,
TestDev const& device,
TestQueue& queue,
const T* src, std::size_t n)
{
auto hbuf = alpaka::allocBuf<T, Idx>(host, Ext1D::all(Idx{n}));
Expand Down
Loading