[tests] remove cuda/hip test duplication with a templated fixture #13
+268
−468
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,221 @@ | ||||||
|
|
||||||
| // shared test for CUDA/HIP | ||||||
|
|
||||||
| template <typename TTag> | ||||||
|
|
||||||
| static void runGpuTests(const std::string &backend) { | ||||||
| std::cout << "\n=== " << backend << " Tests ===\n"; | ||||||
|
|
||||||
| using Acc = alpaka::TagToAcc<TTag, Dim1D, Idx>; | ||||||
| using DevAcc = alpaka::Dev<Acc>; | ||||||
| using PlatformAcc = alpaka::Platform<Acc>; | ||||||
|
|
||||||
| PlatformAcc platform{}; | ||||||
| auto dev = alpaka::getDevByIdx(platform, 0u); | ||||||
| alpaka::Queue<DevAcc, alpaka::NonBlocking> queue{dev}; | ||||||
| sofieBLAS<TTag> blas(queue); | ||||||
|
|
||||||
| alpaka::PlatformCpu hostPlatform{}; | ||||||
| auto hostDev = alpaka::getDevByIdx(hostPlatform, 0u); | ||||||
|
|
||||||
| constexpr int M = 4, N = 3, K = 5; | ||||||
|
|
||||||
| auto hA = alpaka::allocBuf<float, Idx>(hostDev, static_cast<Idx>(M * K)); | ||||||
| auto hB = alpaka::allocBuf<float, Idx>(hostDev, static_cast<Idx>(K * N)); | ||||||
| auto hC = alpaka::allocBuf<float, Idx>(hostDev, static_cast<Idx>(M * N)); | ||||||
| auto hBias = alpaka::allocBuf<float, Idx>(hostDev, static_cast<Idx>(M * N)); | ||||||
|
|
||||||
| float *A = alpaka::getPtrNative(hA); | ||||||
| float *B = alpaka::getPtrNative(hB); | ||||||
| float *bias = alpaka::getPtrNative(hBias); | ||||||
|
|
||||||
| fillSeq(A, M * K); | ||||||
| fillSeq(B, K * N, 1.f, 0.5f); | ||||||
| fillVal(bias, M * N, 0.f); | ||||||
|
|
||||||
| auto dA = alpaka::allocAsyncBuf<float, Idx>(queue, static_cast<Idx>(M * K)); | ||||||
| auto dB = alpaka::allocAsyncBuf<float, Idx>(queue, static_cast<Idx>(K * N)); | ||||||
| auto dC = alpaka::allocAsyncBuf<float, Idx>(queue, static_cast<Idx>(M * N)); | ||||||
| auto dBias = | ||||||
| alpaka::allocAsyncBuf<float, Idx>(queue, static_cast<Idx>(M * N)); | ||||||
|
|
||||||
| alpaka::memcpy(queue, dA, hA); | ||||||
| alpaka::memcpy(queue, dB, hB); | ||||||
| alpaka::memcpy(queue, dBias, hBias); | ||||||
| alpaka::wait(queue); | ||||||
|
|
||||||
| std::vector<float> ref(M * N); | ||||||
| float *C = alpaka::getPtrNative(hC); | ||||||
|
|
||||||
| auto verify = [&](const std::string &name) { | ||||||
| alpaka::memcpy(queue, hC, dC); | ||||||
| alpaka::wait(queue); | ||||||
| checkClose(C, ref.data(), M * N, name); | ||||||
| }; | ||||||
|
|
||||||
| // ---- matmul NN ---- | ||||||
| blas.addLayoutConfig(M, N, K, ldaFor('N', M, K), ldbFor('N', K, N), M, 'N', | ||||||
| 'N'); | ||||||
| std::fill(ref.begin(), ref.end(), 0.f); | ||||||
| refMatmul(ref.data(), A, B, M, N, K, 1.f, 0.f, false, false); | ||||||
| blas.matmul('N', 'N', M, N, K, 1.f, dA, dB, 0.f, dC); | ||||||
| verify(backend + "::matmul NN"); | ||||||
|
|
||||||
| // ---- matmul TN ---- | ||||||
| { | ||||||
| auto hAt = alpaka::allocBuf<float, Idx>(hostDev, static_cast<Idx>(K * M)); | ||||||
| float *At = alpaka::getPtrNative(hAt); | ||||||
| fillSeq(At, K * M); | ||||||
| auto dAt = | ||||||
| alpaka::allocAsyncBuf<float, Idx>(queue, static_cast<Idx>(K * M)); | ||||||
| alpaka::memcpy(queue, dAt, hAt); | ||||||
| alpaka::wait(queue); | ||||||
| blas.addLayoutConfig(M, N, K, ldaFor('T', M, K), ldbFor('N', K, N), M, 'T', | ||||||
| 'N'); | ||||||
| std::fill(ref.begin(), ref.end(), 0.f); | ||||||
| refMatmul(ref.data(), At, B, M, N, K, 1.f, 0.f, true, false); | ||||||
| blas.matmul('T', 'N', M, N, K, 1.f, dAt, dB, 0.f, dC); | ||||||
| verify(backend + "::matmul TN"); | ||||||
| } | ||||||
|
|
||||||
| // ---- matmul NT ---- | ||||||
| { | ||||||
| auto hBt = alpaka::allocBuf<float, Idx>(hostDev, static_cast<Idx>(N * K)); | ||||||
| float *Bt = alpaka::getPtrNative(hBt); | ||||||
| fillSeq(Bt, N * K, 1.f, 0.5f); | ||||||
| auto dBt = | ||||||
| alpaka::allocAsyncBuf<float, Idx>(queue, static_cast<Idx>(N * K)); | ||||||
| alpaka::memcpy(queue, dBt, hBt); | ||||||
| alpaka::wait(queue); | ||||||
| blas.addLayoutConfig(M, N, K, ldaFor('N', M, K), ldbFor('T', K, N), M, 'N', | ||||||
| 'T'); | ||||||
| std::fill(ref.begin(), ref.end(), 0.f); | ||||||
| refMatmul(ref.data(), A, Bt, M, N, K, 1.f, 0.f, false, true); | ||||||
| blas.matmul('N', 'T', M, N, K, 1.f, dA, dBt, 0.f, dC); | ||||||
| verify(backend + "::matmul NT"); | ||||||
| } | ||||||
|
|
||||||
| // ---- matmul alpha=2.5 ---- | ||||||
| std::fill(ref.begin(), ref.end(), 0.f); | ||||||
| refMatmul(ref.data(), A, B, M, N, K, 2.5f, 0.f, false, false); | ||||||
| blas.matmul('N', 'N', M, N, K, 2.5f, dA, dB, 0.f, dC); | ||||||
| verify(backend + "::matmul alpha=2.5"); | ||||||
|
|
||||||
| // ---- gemm NN beta=0 ---- | ||||||
| fillSeq(bias, M * N, 0.1f, 0.1f); | ||||||
| alpaka::memcpy(queue, dBias, hBias); | ||||||
| alpaka::wait(queue); | ||||||
| std::fill(ref.begin(), ref.end(), 0.f); | ||||||
| refGemm(ref.data(), A, B, bias, M, N, K, 1.f, 0.f, false, false); | ||||||
| blas.gemm('N', 'N', M, N, K, 1.f, dA, dB, 0.f, dBias, dC); | ||||||
| verify(backend + "::gemm NN beta=0"); | ||||||
|
|
||||||
| // ---- gemm NN beta=1 ---- | ||||||
| // D_in = bias, so result = A*B + 1*bias_matrix + bias_vec | ||||||
| std::fill(ref.begin(), ref.end(), 0.f); | ||||||
| refGemm(ref.data(), A, B, bias, M, N, K, 1.f, 1.f, false, false); | ||||||
| blas.gemm('N', 'N', M, N, K, 1.f, dA, dB, 1.f, dBias, dC); | ||||||
| verify(backend + "::gemm NN beta=1"); | ||||||
|
|
||||||
| // ---- gemm TN ---- | ||||||
| { | ||||||
| auto hAt = alpaka::allocBuf<float, Idx>(hostDev, static_cast<Idx>(K * M)); | ||||||
| float *At = alpaka::getPtrNative(hAt); | ||||||
| fillSeq(At, K * M); | ||||||
| auto dAt = | ||||||
| alpaka::allocAsyncBuf<float, Idx>(queue, static_cast<Idx>(K * M)); | ||||||
| alpaka::memcpy(queue, dAt, hAt); | ||||||
| alpaka::wait(queue); | ||||||
| blas.addLayoutConfig(M, N, K, ldaFor('T', M, K), ldbFor('N', K, N), M, 'T', | ||||||
| 'N'); | ||||||
| std::fill(ref.begin(), ref.end(), 0.f); | ||||||
| refGemm(ref.data(), At, B, bias, M, N, K, 1.f, 0.f, true, false); | ||||||
| blas.gemm('T', 'N', M, N, K, 1.f, dAt, dB, 0.f, dBias, dC); | ||||||
| verify(backend + "::gemm TN"); | ||||||
| } | ||||||
|
|
||||||
| // ---- gemmrelu: all-positive (relu is identity) ---- | ||||||
| { | ||||||
| auto hAp = alpaka::allocBuf<float, Idx>(hostDev, static_cast<Idx>(M * K)); | ||||||
| auto hBp = alpaka::allocBuf<float, Idx>(hostDev, static_cast<Idx>(K * N)); | ||||||
| auto hBiasz = | ||||||
| alpaka::allocBuf<float, Idx>(hostDev, static_cast<Idx>(M * N)); | ||||||
| float *Ap = alpaka::getPtrNative(hAp); | ||||||
| float *Bp = alpaka::getPtrNative(hBp); | ||||||
| fillSeq(Ap, M * K, 0.1f, 0.1f); | ||||||
| fillSeq(Bp, K * N, 0.1f, 0.1f); | ||||||
| fillVal(alpaka::getPtrNative(hBiasz), M * N, 0.f); | ||||||
| auto dAp = | ||||||
| alpaka::allocAsyncBuf<float, Idx>(queue, static_cast<Idx>(M * K)); | ||||||
| auto dBp = | ||||||
| alpaka::allocAsyncBuf<float, Idx>(queue, static_cast<Idx>(K * N)); | ||||||
| auto dBiasz = | ||||||
| alpaka::allocAsyncBuf<float, Idx>(queue, static_cast<Idx>(M * N)); | ||||||
| alpaka::memcpy(queue, dAp, hAp); | ||||||
| alpaka::memcpy(queue, dBp, hBp); | ||||||
| alpaka::memcpy(queue, dBiasz, hBiasz); | ||||||
| alpaka::wait(queue); | ||||||
| blas.addLayoutConfig(M, N, K, M, K, M, 'N', 'N'); | ||||||
|
Member
There was a problem hiding this comment.
Suggested change
|
||||||
| std::fill(ref.begin(), ref.end(), 0.f); | ||||||
| refGemmRelu(ref.data(), Ap, Bp, alpaka::getPtrNative(hBiasz), M, N, K, 1.f, | ||||||
| 0.f, false, false); | ||||||
| blas.gemmrelu('N', 'N', M, N, K, 1.f, dAp, dBp, 0.f, dBiasz, dC); | ||||||
| verify(backend + "::gemmrelu all-positive"); | ||||||
| } | ||||||
|
|
||||||
| // ---- gemmrelu: alpha=-1 forces negatives -> clamped to zero ---- | ||||||
| { | ||||||
| auto hBiasz = | ||||||
| alpaka::allocBuf<float, Idx>(hostDev, static_cast<Idx>(M * N)); | ||||||
| fillVal(alpaka::getPtrNative(hBiasz), M * N, 0.f); | ||||||
| auto dBiasz = | ||||||
| alpaka::allocAsyncBuf<float, Idx>(queue, static_cast<Idx>(M * N)); | ||||||
| alpaka::memcpy(queue, dBiasz, hBiasz); | ||||||
| alpaka::wait(queue); | ||||||
| std::fill(ref.begin(), ref.end(), 0.f); | ||||||
| refGemmRelu(ref.data(), A, B, alpaka::getPtrNative(hBiasz), M, N, K, -1.f, | ||||||
| 0.f, false, false); | ||||||
| blas.gemmrelu('N', 'N', M, N, K, -1.f, dA, dB, 0.f, dBiasz, dC); | ||||||
| verify(backend + "::gemmrelu alpha=-1 (clamped)"); | ||||||
| } | ||||||
|
|
||||||
| // ---- gemmrelu with mixed bias ---- | ||||||
| fillSeq(bias, M * N, -5.f, 2.f); | ||||||
| alpaka::memcpy(queue, dBias, hBias); | ||||||
| alpaka::wait(queue); | ||||||
| std::fill(ref.begin(), ref.end(), 0.f); | ||||||
| refGemmRelu(ref.data(), A, B, bias, M, N, K, 1.f, 0.f, false, false); | ||||||
| blas.gemmrelu('N', 'N', M, N, K, 1.f, dA, dB, 0.f, dBias, dC); | ||||||
| verify(backend + "::gemmrelu with mixed bias"); | ||||||
|
|
||||||
| // ---- gemmgelu NN ---- | ||||||
| fillVal(bias, M * N, 0.f); | ||||||
| alpaka::memcpy(queue, dBias, hBias); | ||||||
| alpaka::wait(queue); | ||||||
| std::fill(ref.begin(), ref.end(), 0.f); | ||||||
| refGemmGelu(ref.data(), A, B, bias, M, N, K, 1.f, 0.f, false, false); | ||||||
| blas.gemmgelu('N', 'N', M, N, K, 1.f, dA, dB, 0.f, dBias, dC); | ||||||
| verify(backend + "::gemmgelu NN"); | ||||||
|
|
||||||
| // ---- gemmgelu with bias ---- | ||||||
| fillSeq(bias, M * N, -2.f, 0.5f); | ||||||
| alpaka::memcpy(queue, dBias, hBias); | ||||||
| alpaka::wait(queue); | ||||||
| std::fill(ref.begin(), ref.end(), 0.f); | ||||||
| refGemmGelu(ref.data(), A, B, bias, M, N, K, 1.f, 0.f, false, false); | ||||||
| blas.gemmgelu('N', 'N', M, N, K, 1.f, dA, dB, 0.f, dBias, dC); | ||||||
| verify(backend + "::gemmgelu with bias"); | ||||||
|
|
||||||
| // ---- edge: zero A ---- | ||||||
| { | ||||||
| auto hZero = alpaka::allocBuf<float, Idx>(hostDev, static_cast<Idx>(M * K)); | ||||||
| fillVal(alpaka::getPtrNative(hZero), M * K, 0.f); | ||||||
| auto dZero = | ||||||
| alpaka::allocAsyncBuf<float, Idx>(queue, static_cast<Idx>(M * K)); | ||||||
| alpaka::memcpy(queue, dZero, hZero); | ||||||
| alpaka::wait(queue); | ||||||
| std::fill(ref.begin(), ref.end(), 0.f); | ||||||
| blas.matmul('N', 'N', M, N, K, 1.f, dZero, dB, 0.f, dC); | ||||||
| verify(backend + "::matmul zero-A"); | ||||||
| } | ||||||
| } | ||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name the file inside a directory, so the structure becomes, and add cpu tests as well:
this way we could add some E2E tests as well if we need to extend this in the future.