Skip to content

Summoner Master Tree Finishup - #856

Open
ze-dom wants to merge 7 commits into
MUnique:masterfrom
ze-dom:summoner_master_tree_finishup
Open

Summoner Master Tree Finishup#856
ze-dom wants to merge 7 commits into
MUnique:masterfrom
ze-dom:summoner_master_tree_finishup

Conversation

@ze-dom

@ze-dom ze-dom commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Bugfixes

  • Fixed skill values and effects for SleepStrengthener and DrainLifeStrengthener master skills.

else
{
restoreHealth += (attackerPlayer.Attributes[Stats.TotalEnergy] / 15) + (target.Attributes[Stats.Level] / 2.5f);
}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zTeamS6.3, emu

The client's tooltip is bugged - it does not add to skill damage.
Image

magicEffect.StopByDeath = true;
magicEffect.Duration = this.Context.CreateNew<PowerUpDefinitionValue>();
magicEffect.Duration.ConstantValue.Value = 30; // 30 Seconds
magicEffect.Duration.MaximumValue = 180;

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

emu

Comment thread src/GameLogic/Player.cs
skillEntry.PowerUpChance = new CombinedElement(skillEntry.PowerUpChance, new ConstantElement(bonusChance));
skillEntry.PowerUpChancePvp = new CombinedElement(skillEntry.PowerUpChancePvp, new ConstantElement(bonusChance));
}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zTeamS6.3, emu

Again, tooltip is inaccurate.
Image

@ze-dom
ze-dom marked this pull request as ready for review July 27, 2026 19:00
@ze-dom
ze-dom marked this pull request as draft July 28, 2026 10:01
@ze-dom
ze-dom marked this pull request as ready for review July 28, 2026 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant