feat!: create the cache deletion job instead of the seeding job (MAPCO-11265) - #119
Open
almog8k wants to merge 6 commits into
Open
feat!: create the cache deletion job instead of the seeding job (MAPCO-11265)#119almog8k wants to merge 6 commits into
almog8k wants to merge 6 commits into
Conversation
Adds the Update_Delete_Cache / Swap_Delete_Cache job types and the cacheDeletion task config, wired through to the chart in the same change. Pins raster-shared to the build exporting GEODETIC_GRIDS.
Composes the redis key prefix from the mapproxy cache name and the configured grid, emits a prefix-wipe task for swap-update and streamed range tasks for update, and fails a partially-populated job explicitly.
…O-11265) Both ingestion finalize handlers now create an Update_Delete_Cache or Swap_Delete_Cache job instead of a seeding job, and SeedingJobCreator with its SeedMode and Seed* param types is removed. BREAKING CHANGE: overseer no longer creates seeding jobs.
…1265) The previous toMatchObject assertion used an empty parameters object, which matches anything, so ingestionJobId and ingestionJobType were unasserted. Verified the new assertion fails when they are removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues: MAPCO-11265 (epic MAPCO-11261)
Further information:
Replaces the MapProxy tile-cache seeding job with a cache deletion job. On ingestion finalize, overseer now tells the
cleanerworker which Redis tile keys to drop instead of drivingmapproxy-seed; tiles repopulate lazily on cache miss.Cleaner resolves its strategy from a combined job+task token, so the job type selects the behaviour while the task type stays
tiles-deletion:Update_Delete_CacheSwap_Delete_CachedelaySecondsThe Redis key prefix is composed as
${cacheName}_${grid}(mapproxyloader.py's rule) because mapproxy-api reports neither a prefix nor a grid. Verified against a production key and pinned as a regression test.GEODETIC_GRIDStherefore gates construction:footprintToTileRangesonly implements the geodetic grid, and against any other it would return plausible ranges for the wrong tiles.Not deployable on its own. job-tracker has no handler or config entry for the two new job types —
getJobHandlerthrowsBadRequestErrorfor anything outside its switch — so it would reject every task event for these jobs. Ticket pending. It also completes a job oncompletedTasks === taskCount, which needs a decision since tasks are streamed after the job is created. Cleaner work is MAPCO-11263/11264; both dependency pins are CI tarballs to be swapped for published versions before production (MAPCO-11267).BREAKING CHANGE: overseer no longer creates seeding jobs. Ingestion finalize now creates an Update_Delete_Cache or Swap_Delete_Cache job, and the Ingestion_Seed job type is no longer produced.