Skip to content

Add DHCP static reservation read - #9

Merged
MarcLeinenDE merged 7 commits into
mainfrom
dev/sdk-dhcp-static-read
Sep 8, 2026
Merged

Add DHCP static reservation read#9
MarcLeinenDE merged 7 commits into
mainfrom
dev/sdk-dhcp-static-read

Conversation

@MarcLeinenDE

@MarcLeinenDE MarcLeinenDE commented Sep 8, 2026

Copy link
Copy Markdown
Owner

Adds a small read-only helper for the upstream live-verified normal-admin router/router_get_dhcp_static_ip contract.

Scope:

  • client.lan.static_reservations()router/router_get_dhcp_static_ip
  • exact GET routing locked down by offline tests
  • complete firmware JSON response is preserved raw because the upstream public contract does not freeze a stable nested response schema
  • existing read-only LAN/DNS physical smoke extended with the new helper

Safety/privacy:

  • no router_set_dhcp_static_ip
  • no DHCP/LAN configuration write
  • physical smoke does not print or assert concrete reservation IP/MAC values
  • no invented field names or normalization

Physical ACIY.3 evidence (2026-09-08):

  • targeted test_lan_dns_reads passed 1/1 in 0.92 s on Python 3.13.5
  • exercised existing LAN/DNS reads plus router/router_get_dhcp_static_ip
  • no DHCP/LAN write and no concrete reservation IP/MAC values printed

Documentation:

  • CHANGELOG.md records helper and physical validation
  • docs/dhcp-static-reservations-read.md records scope, privacy and evidence
  • no nr2301-api change is needed because this run introduced no new wire semantics; the getter was already upstream LIVE_VERIFIED, ADMIN_OK, READ_OR_LOW_SIDE_EFFECT

Validation:

  • initial PR CI run #227: Python 3.10/3.11/3.12/3.13 and package all SUCCESS
  • final PR patch reviewed; only intended SDK/helper/test/evidence changes remain

@MarcLeinenDE MarcLeinenDE changed the title WIP: add DHCP static reservation read Add DHCP static reservation read Sep 8, 2026
@MarcLeinenDE
MarcLeinenDE marked this pull request as ready for review September 8, 2026 11:23
@MarcLeinenDE
MarcLeinenDE merged commit 40a59c7 into main Sep 8, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant