Repository navigation
Draggable tabs with live slide while dragging - #10
Merged
Merged
Conversation
Tabs are drag sources (NSItemProvider with the tab URL) and drop targets (plainText onDrop): dropping a tab onto another takes its position, browser-style. PDFReaderState.moveTab re-syncs the active tab index from its URL after the move so the displayed document never reloads, and the reordered session persists through the tabURLs observer. The hovered target shows a dashed accent border. Per-tab drag/drop wiring lives in a small TabItem view so the modifier chain type-checks fast.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan