Repository navigation
fix(release): download only the release's artifacts - #66
Merged
Merged
Conversation
The release job downloaded every artifact of the run, including the build record that docker/build-push-action uploads (*.dockerbuild), which actions/download-artifact fails to extract. The Linux build no longer uploads that record, and the release job downloads its artifacts by name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
The
v0.1.0-rc.2Release run built and packaged all three platforms, then failed in thereleasejob's first step:docker/build-push-action@v6uploads a build record (*.dockerbuild) as an artifact of the run. Thereleasejob downloaded every artifact, andactions/download-artifactcannot extract that one. The five artifacts the release actually uses downloaded fine. Nothing was published, because the "Publish the release" step was skipped.The fix:
DOCKER_BUILD_RECORD_UPLOAD: false, so the record is no longer uploaded.releasejob downloads its artifacts by name:linux,macos,windows,notesandthird-party.After merge, the tag
v0.1.0-rc.2has to move to the new main commit. Re-running the failed run would use the workflow file at the tag's commit, which still has the bug.How it was tested
The workflow YAML parses. A full test needs a Release run: either a dry run by
workflow_dispatchon main after merge, or the re-pushed tag.Documentation
docs/guide/) shows it (a chapter updated or added, examples tested withcargo test -p tripletrail-server --test guide)docs/and the CHANGELOG entry describe itGenerated by Claude Code