Repository navigation
Money in integer cents (#140) - #158
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…140) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
4 tasks
The toast named date, invoice number and subtotal even when those were fine and only the server's tax and total were missing (no company picked, or the total request failed). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1 of 11 tasks
MatheusCastro99
marked this pull request as ready for review
November 4, 2026 19:30
Owner
Author
|
Ready to merge at G2: no blocking findings. Fixed after G2: the Generate PDF toast now says when the tax and total are what's missing (a4bce16), and ADR-012's status text is updated (752df34). One narrow re-review at 752df34: approve, no findings. Declined by the owner: a retry after a failed total request. Three pre-existing bugs went to backlog #153. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #140. Closes #145. Plan: #140 (comment)
Backlog #153 items this change affects
To update on #153 when #140 closes:
InvoicePage.jsx, the total effect), and a refused or failed request shows its message.selectCustomer/handleTaxstill have no guard.console.log(tableData)is gone fromPdfPage.jsx.console.log(customerInfo, info)is still inPdfDocument.jsx.🤖 Generated with Claude Code