Skip to content

ci: reduce duplicate runs, cache Docker layers, and characterize attack CLI - #25

Merged
mohamed2ze merged 4 commits into
sprint5/attacks-dashboard-handofffrom
chore/ci-efficiency-cli-tests
Nov 18, 2026
Merged

mohamed2ze merged 4 commits into
sprint5/attacks-dashboard-handofffrom
chore/ci-efficiency-cli-tests

Conversation

@mohamed2ze

Copy link
Copy Markdown
Collaborator

What

  • Check pull requests and main pushes instead of duplicate feature push + PR runs.
  • Add owner-approved SHA-pinned official Docker actions for persistent BuildKit caching; load the image for the existing Trivy scan, never publish it.
  • Add 16 attack CLI characterization cases and two CI configuration guards. Application code and research gates remain unchanged.
  • Record measurements and limitations in docs/efficiency_audit.md.

Why

The audit observed duplicate CI runs for the same commit (~305 redundant job-seconds), uncached hosted Docker builds (99–117 seconds), and 0% attack CLI coverage.

Verification

  • Full suite: 568 passed, 6 expected optional skips.
  • Coverage: 90% combined; attack CLI 0% -> 96%.
  • make lint and make security passed.
  • Local BuildKit cache export/import and image build passed; filtered fixed HIGH/CRITICAL Trivy scan passed.
  • Hosted cache timing/reuse awaits this PR CI. Local warm-cache timings are not a hosted speedup claim.

Review and integration

Owner requested integration into sprint5/attacks-dashboard-handoff and deletion of the task branch after successful merge. Keep focused commits via a normal merge. Repository contribution rules require at least one reviewer; do not bypass reviews or failing checks. CI has no deployment steps, and this change does not publish an image.

Follow-ups

Measure first/subsequent hosted cache builds. Runtime response-serialization optimization was not approved and is not included.

@mohamed2ze
mohamed2ze merged commit b7d1773 into sprint5/attacks-dashboard-handoff Nov 18, 2026
3 checks passed
@mohamed2ze
mohamed2ze deleted the chore/ci-efficiency-cli-tests branch November 18, 2026 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant