Repository navigation
Conversation
melroy89
commented
Oct 5, 2026
Member
Author
|
ok rebased to latest main now. |
melroy89
force-pushed
the
feat/stopforumspam-registration
branch
from
October 8, 2026 19:43
2f80933 to
88ac92c
Compare
melroy89
requested review from
BentiGorlich and
blued-gear
and removed request for
blued-gear
October 9, 2026 18:29
melroy89
force-pushed
the
feat/stopforumspam-registration
branch
from
October 13, 2026 14:04
9070331 to
4ad8211
Compare
Member
Author
|
Rebased |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add optional StopForumSpam IP screening (free service) to password and SSO registrations. Lookups and automatic rejection are disabled by default and configurable in
/admin/settings. Automatic rejection requires a database match and both confidence and frequency thresholds (defaults: 95% and 5), before any account or signup messages are created.Pending applications show the registration-time screening result on the approval page and send an approval-request email to admins who enable signup notifications. The private snapshot is erased on approval, rejection, or deletion; existing in-app notifications are preserved.
Rationale
I got sick of all the spam users and bot registrations on my server.
Additional information
This PR targets
upgrade_dependenciesand depends on #2162, keeping the feature diff separate from the dependency upgrade.Validation
Stored screening snapshot
registration_screeningis a nullable JSONB snapshot retained only for pending applications when screening is enabled. Approval, rejection, or deletion clears it toNULL; automatic rejection creates no user record. It is excluded from user API serialization.Illustrative example:
{ "ip": "192.0.2.10", "status": "matched", "frequency": 12, "confidence": 97.5, "lastseen": "2026-10-05 10:00:00", "checked_at": "2026-10-05T12:00:00+00:00", "cached": false, "failure": null }statusismatched,no_match, orunavailable. Unavailable checks have null result fields and a failure reason such asrequest_failedorquota_exhausted.Screenshots
Captured from the isolated test instance. The approval example uses a fictional account, reserved example IP, and illustrative screening data.
Desktop settings
Mobile settings
Signup approval