Fix captcha on login page - #623
Merged
GuillaumeRoques merged 1 commit intoAug 14, 2026
Merged
Conversation
Signed-off-by: Guillaume Roques <guillaume.roques@gmail.com>
There was a problem hiding this comment.
Pull request overview
This PR aims to fix login-page CAPTCHA enforcement by ensuring the invisible reCAPTCHA flow actually submits the login form on success and by validating the reCAPTCHA token server-side before the security check proceeds.
Changes:
- Register a
LoginCaptchaSubscriberservice to verifyg-recaptcha-responseonfos_user_security_checkPOST requests. - Update the login reCAPTCHA widget configuration to use a callback and add a JS handler that submits the form on success.
- Add a form
id/class hook needed for the callback-driven submit.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/UserBundle/Resources/config/services.yml | Registers the login CAPTCHA kernel event subscriber and wires required arguments. |
| src/UserBundle/EventSubscriber/LoginCaptchaSubscriber.php | Replaces EWZ form-based validation with direct server-side verification using ReCaptcha\ReCaptcha. |
| src/UserBundle/Controller/SecurityController.php | Adds the reCAPTCHA callback option for the invisible widget. |
| app/Resources/FOSUserBundle/views/Security/login_content.html.twig | Defines the callback JS and adds id/class to the login form for submission on CAPTCHA success. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+48
to
+50
| $recaptcha = new ReCaptcha($this->privateKey); | ||
| $recaptcha->setExpectedHostname($request->getHost()); | ||
| $response = $recaptcha->verify($request->request->get('g-recaptcha-response'), $request->getClientIp()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.