Repository navigation
fix(studio): accept the last-frame lookahead of stock sequence group files - #2
Merged
Merged
Conversation
…files GoldSrc's animators read the sample after a run's last span at its last frame, with no weight. Every stock Half-Life sequence group file ends before that sample, so CheckStudioSequenceGroup rejected them. Sequence groups may now end that read up to UTIL_ASSETS_INTEGRITY_SEQUENCE_GROUP_TAIL_BYTES (4) past their bytes; callers that animate a group keep that many zeroed bytes after it. Main models stay checked strictly. The model directory scan now checks each sequence group against its main model. Ported from HLND2T-DiligentGraphics 4b3f52c7. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GoldSrc's animators read the first sample after a run's last span at its last frame, with no weight (the frame is clamped to
numframes - 1, wheresis 0). Every stock Half-Life sequence group file (scientist01.mdl,barney01.mdl, ...) ends before that sample, up to twomstudioanimvalue_tshort, soCheckStudioSequenceGroup()rejected all of them.UTIL_ASSETS_INTEGRITY_SEQUENCE_GROUP_TAIL_BYTES(4).CheckStudioSequenceGroup()lets only the interpolation lookahead end up to that many bytes past the group; the samples themselves must still be inside the file.UtilAssetsIntegrityAPI_001vtable and result layouts are unchanged.docs/studio-validation.md,README.md,README.zh-CN.md,memory/project_overview.md.Ported from HLND2T-DiligentGraphics
4b3f52c7. After this PR the shared sources, header and tests match that copy byte for byte (ignoring line endings), so HLND can consume this repository as a submodule.Verification (local, Windows, VS 2022, x86)
scripts/build-UtilAssetsIntegrity-x86-Release.bat: exit 0, CTest 1/1, installed-DLL smoke test passed.scripts/build-UtilAssetsIntegrity-x86-Debug.bat: exit 0, CTest 1/1, installed-DLL smoke test passed.src/change fail withlast frame lookahead in the caller's tail (expected 0, got 7).valve/models:Scanned 310 MDL files and 20 sequence groups against their main models; rejected 1.The only rejection is the olddoctor.mdl(not version 10).format-check: 6 files, 0 with differences.GitHub Actions results are not part of this local verification.
🤖 Generated with Claude Code