Skip to content

fix(career): localize profile confirmation dialogs - #30

Merged
hzqst merged 1 commit into
mainfrom
fix/career-confirmation-localization
Oct 25, 2026
Merged

hzqst merged 1 commit into
mainfrom
fix/career-confirmation-localization

Conversation

@hzqst

@hzqst hzqst commented Oct 25, 2026

Copy link
Copy Markdown
Contributor

The rewritten Career storage confirmation always displayed Career profile and English query text, even when the game was running in Chinese. Reuse the existing delete/overwrite localization tokens and format the deletion query with the complete UTF-8 profile name converted to Unicode. Missing tokens fall back to readable English.

The existing confirmation tokens, cancellation handling and verified deletion ownership remain intact. Official translations already exist in czero_%language%.txt; no resource override or gamedata change is needed. The first issue attachment matches the hardcoded English path, while neither attachment demonstrates the bare-token wording in the issue text.

Fixes MetaHookSv/MetaHookSv#951.
Root-cause evidence: MetaHookSv/MetaHookSv#951 (comment)

Validation:

  • MSVC x86 Release build, all 8 existing CTests, pinned format-check (66 files), and git diff --check passed. Existing unrelated ClientVGUI.cpp C4018 warning remains.
  • Live Windows czero engine 10210, schinese, 1280x720: localized deletion title/body with a complete mixed Chinese/ASCII profile name longer than the native 31-byte boundary; localized overwrite title/body.
  • Delete cancel and overwrite cancel preserved the task profile SHA-256. Confirmed deletion removed the task profile while pre-existing profile hashes were unchanged.
  • Game exited normally; all 21 backed-up game files were restored and SHA-256 verified. Verification notes and local evidence locations are recorded in memory/build_and_verification.md.

English language, forced missing-token fallback, other engine builds and extreme-length layout were not tested in-game. No tests asserting UI wording were added; existing storage/Unicode regressions and live UI checks provide the relevant validation.

Co-Authored-By: Codex <codex@openai.com>
@hzqst
hzqst merged commit 120fae7 into main Oct 25, 2026
3 checks passed
@hzqst
hzqst deleted the fix/career-confirmation-localization branch October 25, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[VGUI2Extension][czero] 删除档案确认框标题缺少本地化翻译 Career_DeleteProfileTitle

1 participant