Repository navigation
fix(career): localize profile confirmation dialogs - #30
Merged
Merged
Conversation
Co-Authored-By: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rewritten Career storage confirmation always displayed
Career profileand English query text, even when the game was running in Chinese. Reuse the existing delete/overwrite localization tokens and format the deletion query with the complete UTF-8 profile name converted to Unicode. Missing tokens fall back to readable English.The existing confirmation tokens, cancellation handling and verified deletion ownership remain intact. Official translations already exist in
czero_%language%.txt; no resource override or gamedata change is needed. The first issue attachment matches the hardcoded English path, while neither attachment demonstrates the bare-token wording in the issue text.Fixes MetaHookSv/MetaHookSv#951.
Root-cause evidence: MetaHookSv/MetaHookSv#951 (comment)
Validation:
English language, forced missing-token fallback, other engine builds and extreme-length layout were not tested in-game. No tests asserting UI wording were added; existing storage/Unicode regressions and live UI checks provide the relevant validation.