Repository navigation
fix(career): localize missing mission data errors - #31
Merged
Merged
Conversation
Co-Authored-By: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes MetaHookSv/MetaHookSv#952.
When Career mission data is missing or corrupt, native
CCareerMapFrame::OnThinkcreates a modalMessageBoxwith literal English title/body strings. Neither string starts with a localization token, so adding translations alone cannot translate this window. This path is separate from the plugin's profile-storageShowErrorand the #951 confirmation-dialog fix.Reuse the existing gamedata-resolved narrow
MessageBoxconstructor and hook it only for czero, excluding Deleted Scenes. Replace the exact native title/body pair with two plugin tokens when each translation exists. The original constructor, error checks and modal lifecycle remain in use; missing translations retain the native English strings.VGUI2Extension_CareerDataErrorTitleandVGUI2Extension_CareerDataErrorTextin UTF-16 LE BOM English and Simplified Chinese resources.-forcelangselection.Validation:
git diff --checkpassed.Mapsto reach the same native no-triplet error branch. This was not a direct deleted-Normal.vdftest: missing per-pack files can fall back to globalCareerGame<difficulty>.vdf. The checksum-failure branch and other engine builds were not separately exercised.Static diagnosis: MetaHookSv/MetaHookSv#952 (comment)