Skip to content

refactor: share file upload operation - #229

Open
victor0602 wants to merge 1 commit into
mainfrom
codex/share-file-operations
Open

refactor: share file upload operation#229
victor0602 wants to merge 1 commit into
mainfrom
codex/share-file-operations

Conversation

@victor0602

@victor0602 victor0602 commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

What changed

  • Extract the file upload path validation, multipart construction, endpoint selection, and request execution into one internal operation.
  • Reuse that operation from both the CLI command and FileSDK.
  • Keep CLI prompting, dry-run, quiet output, and SDK-specific errors unchanged.

Why

The CLI and SDK previously maintained separate upload implementations, so fixes could land in one path and be missed in the other.

Impact

CLI and SDK behavior stays compatible while the upload protocol now has a single implementation and stronger multipart coverage.

Checks

  • bun test — 450 passed
  • bun run typecheck
  • bun run build
  • bun run lint — no errors; one pre-existing test warning
  • git diff --check

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@victor0602
victor0602 marked this pull request as ready for review August 5, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant