Skip to content

refactor: share SDK client context - #230

Open
victor0602 wants to merge 1 commit into
mainfrom
codex/share-sdk-client
Open

refactor: share SDK client context#230
victor0602 wants to merge 1 commit into
mainfrom
codex/share-sdk-client

Conversation

@victor0602

@victor0602 victor0602 commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

What changed

  • Add a shared SDK client context that resolves configuration once.
  • Reuse the same context and config across all MiniMaxSDK child modules.
  • Preserve direct construction of individual SDK modules with MiniMaxSDKOptions.

Why

Constructing MiniMaxSDK previously rebuilt the same configuration independently for every child SDK.

Impact

All child SDKs now observe one consistent configuration snapshot without breaking standalone SDK module usage.

Checks

  • bun test — 451 passed
  • bun run typecheck
  • bun run lint — no errors; one pre-existing test warning
  • git diff --check

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

@victor0602
victor0602 marked this pull request as ready for review August 5, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant