GEOPY-2731: Replace InputFile for BaseUIJson class - #56
Open
domfournier wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates surface-app drivers to use geoapps_utils.base.Driver directly (removing the custom BaseSurfaceDriver/InputFile pathway) as part of the UIJson-related refactor, and refreshes dependency pins/locks accordingly.
Changes:
- Switch
iso_surfacesandsurface_normalsdrivers to inherit fromgeoapps_utils.base.Driverand align behavior with the new base driver pattern (e.g., returning created objects). - Remove
surface_apps/driver.py(BaseSurfaceDriver) and associatedInputFilehandling. - Update
geoh5py/geoapps-utilsgit refs inpyproject.tomland regenerate conda-lock files.
Reviewed changes
Copilot reviewed 16 out of 18 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| surface_apps/surface_normals/driver.py | Migrates to geoapps_utils.base.Driver and returns generated Points outputs. |
| surface_apps/iso_surfaces/driver.py | Migrates to geoapps_utils.base.Driver and refactors the main execution method (now run). |
| surface_apps/driver.py | Removes the custom BaseSurfaceDriver abstraction and InputFile-based parameter building. |
| pyproject.toml | Updates geoh5py and geoapps-utils git refs to the UIJson feature branch. |
| environments/py-3.13-win-64.conda.lock.yml | Regenerated lockfile reflecting updated dependency resolution. |
| environments/py-3.13-win-64-dev.conda.lock.yml | Regenerated dev lockfile reflecting updated dependency resolution. |
| environments/py-3.13-linux-64.conda.lock.yml | Regenerated lockfile reflecting updated dependency resolution. |
| environments/py-3.13-linux-64-dev.conda.lock.yml | Regenerated dev lockfile reflecting updated dependency resolution. |
| environments/py-3.12-win-64.conda.lock.yml | Regenerated lockfile reflecting updated dependency resolution. |
| environments/py-3.12-win-64-dev.conda.lock.yml | Regenerated dev lockfile reflecting updated dependency resolution. |
| environments/py-3.12-linux-64.conda.lock.yml | Regenerated lockfile reflecting updated dependency resolution. |
| environments/py-3.12-linux-64-dev.conda.lock.yml | Regenerated dev lockfile reflecting updated dependency resolution. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #56 +/- ##
===========================================
- Coverage 77.40% 76.54% -0.87%
===========================================
Files 5 5
Lines 239 243 +4
Branches 29 30 +1
===========================================
+ Hits 185 186 +1
- Misses 44 47 +3
Partials 10 10
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2731 - Replace InputFile for BaseUIJson class