Fix/mobile tsconfig path aliases - #586
Conversation
…e .well-known files for passkeys
…C_RP_ID / NEXT_PUBLIC_ORIGIN)
|
@rhoggs-bot-test-account is attempting to deploy a commit to the miracle656's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@Davoski1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
Please rebase onto |
|
Thanks @Davoski1 — reviewed. Mixed after the config migration:
Could you close this and open a focused PR for just the |
|
Apologies — this sat unreviewed for a month while What happened: PR #508 (
And the domain-association files are now hosted for real, not as examples: So the gap you were closing is closed. I have checked Specific to this PR: the This PR is also cumulative over #585 and #584 (6 files ⊃ 5 ⊃ 3), so all three are in the same position. Not closing it — your call. Sorry the wait made it moot; the tsconfig instinct was right, it just got there via another PR. |
Summary
Configure the mobile TypeScript project to use the same
@/path alias as the web wallet by mapping"@/*": ["./*"]. This makes imports consistent across mobile and web and prevents import/type errors when moving code between the apps.Changes
frontend/mobile/tsconfig.json:"@/*"path mapping from["./app/*"]to["./*"]."@/assets/*": ["./assets/*"]mapping.Why
The web wallet uses
"@/*": ["./*"], but the mobile app previously mapped@/*only to./app/*. That made many@/...imports resolve differently on mobile vs web, causing type and resolution issues. Unifying the alias improves developer ergonomics and CI consistency.Testing / Verification
tsc --noEmitin thefrontend/mobileworkspace (or rely on CI) to verify no resolution/type errors.Closes 9. tsconfig + path aliases #437