Fix: Multisig is readable in light mode - #677
Merged
Miracle656 merged 2 commits intoAug 27, 2026
Merged
Conversation
Co-authored-by: Rahul Sain <rahulsainlll@users.noreply.github.com>
Co-authored-by: Rahul Sain <rahulsainlll@users.noreply.github.com>
|
@rahulsainlll Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
|
@cursoragent is attempting to deploy a commit to the miracle656's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/multisigwas unreadable in light mode because 23 colours were hardcoded to the dark palette (rgba(246,247,248, α)and near-white fills). Those now use the existing theme tokens so light mode can invert them.Related issue
Closes #671
Type of change
Component
Checklist
cargo testpasses (contracts)npm run typecheckpasses (wallet / sdk / agent)npm run buildpasses (wallet / agent)What changed
rgba(246,247,248, 0.3–0.5)→var(--text-muted)rgba(246,247,248, 0.7+)→var(--off-white)rgba(255,255,255, 0.01–0.02)and the sign-input fill →var(--surface)rgba(246,247,248, 0.08)proposal-badge fill →var(--surface-md)var(--border-dim)color-mixwithvar(--teal)so it tracks light-mode tealvar(--near-black)so it actually goes light with the themeSemantic reds (remove / error) are unchanged — they are readable on both backgrounds and match the rest of the wallet.
How tested
cd frontend/wallet && npm run typecheck— cleanrgba(246,247,248, …)or near-white fills left underapp/multisig/