Skip to content

Fix: Multisig is readable in light mode - #677

Merged
Miracle656 merged 2 commits into
Miracle656:mainfrom
rahulsainlll:cursor/fix-multisig-light-mode-729f
Aug 27, 2026
Merged

Fix: Multisig is readable in light mode#677
Miracle656 merged 2 commits into
Miracle656:mainfrom
rahulsainlll:cursor/fix-multisig-light-mode-729f

Conversation

@rahulsainlll

Copy link
Copy Markdown
Contributor

Summary

/multisig was unreadable in light mode because 23 colours were hardcoded to the dark palette (rgba(246,247,248, α) and near-white fills). Those now use the existing theme tokens so light mode can invert them.

Related issue

Closes #671

Type of change

  • Bug fix
  • New feature
  • Refactor
  • Docs
  • Tests
  • CI / tooling

Component

  • Wallet frontend
  • SDK
  • Contracts
  • Agent

Checklist

  • I have read CONTRIBUTING.md
  • cargo test passes (contracts)
  • npm run typecheck passes (wallet / sdk / agent)
  • npm run build passes (wallet / agent)
  • I added or updated tests where relevant
  • I updated docs / README where relevant

What changed

  • rgba(246,247,248, 0.3–0.5)var(--text-muted)
  • rgba(246,247,248, 0.7+)var(--off-white)
  • rgba(255,255,255, 0.01–0.02) and the sign-input fill → var(--surface)
  • rgba(246,247,248, 0.08) proposal-badge fill → var(--surface-md)
  • Dashed “Add Signer” edge → var(--border-dim)
  • Executed-proposal teal tint uses color-mix with var(--teal) so it tracks light-mode teal
  • Theme toggle is next to the heading (the old one sat in a nav the app shell hides)
  • Content column paints var(--near-black) so it actually goes light with the theme

Semantic reds (remove / error) are unchanged — they are readable on both backgrounds and match the rest of the wallet.

How tested

  • cd frontend/wallet && npm run typecheck — clean
  • Grep: no rgba(246,247,248, …) or near-white fills left under app/multisig/
  • Browser: wizard + queue empty/error in both themes

cursoragent and others added 2 commits August 27, 2026 12:46
Co-authored-by: Rahul Sain <rahulsainlll@users.noreply.github.com>
Co-authored-by: Rahul Sain <rahulsainlll@users.noreply.github.com>
@drips-wave

drips-wave Bot commented Aug 27, 2026

Copy link
Copy Markdown

@rahulsainlll Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@vercel

vercel Bot commented Aug 27, 2026

Copy link
Copy Markdown

@cursoragent is attempting to deploy a commit to the miracle656's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Miracle656
Miracle656 merged commit 071ebb0 into Miracle656:main Aug 27, 2026
9 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

C:/Program Files/Git/multisig is unreadable in light mode — 23 hardcoded dark-palette colours

3 participants