Build the committed functions snapshot before regenerating it - #17
Merged
estebanzimanyi merged 1 commit intoAug 29, 2026
Merged
Conversation
The workflow regenerates the functions package and builds the result, so every step speaks for freshly derived code while a `go get` consumer compiles the committed snapshot. Compiling that snapshot first, against the provisioned libmeos, is the only place its own compilability is decided; afterwards the generator has overwritten it. The drift notice stays informational, and for a reason: MobilityDB master moves independently of this repo, so a difference between the snapshot and a fresh catalog is ordinary and a contributor cannot act on it. A snapshot that no longer BUILDS is a different thing, it reaches consumers, and the fix is in this repo: regenerate and commit. The step fails on the snapshot as it stood before the last refresh, naming C.RTreeSearchOp, and passes on the snapshot in the tree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build the committed functions snapshot before regenerating it. The workflow regenerates the functions package and builds the result, so every step speaks for freshly derived code while a
go getconsumer compiles the committed snapshot; compiling that snapshot first, against the provisioned libmeos, is the only place its own compilability is decided, because afterwards the generator has overwritten it. The drift notice stays informational and says why: MobilityDB master moves independently of this repo, so a difference between the snapshot and a fresh catalog is ordinary and a contributor cannot act on it, while a snapshot that fails to build reaches consumers and is fixable here by regenerating and committing. The step is proven in both directions against the real case: it exits 1 on the snapshot as it stood before the last refresh, naming C.RTreeSearchOp at functions/meos_meos.go:312, and exits 0 on the snapshot in the tree.