Follow a delegating wrapper to the literal it binds - #89
Merged
estebanzimanyi merged 1 commit intoAug 27, 2026
Merged
Conversation
A wrapper that names no MEOS call of its own passes the call info to a shared helper and binds the rest there: `Tjsonb_object_field` is `Tjsonb_object_field_common(fcinfo, false)` over a helper that calls `tjsonb_object_field(temp, key, astext, null_handle)`. The pass follows that hop, matching the literals to the helper's parameters by position, so an argument of the MEOS call naming one of them resolves to the literal behind it. Each catalog entry names one wrapper, so the sibling binding the opposite literal is a separate entry and the two stay distinct. The bound-literal count over MobilityDB master reads 153 against 87, with every previously captured literal unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A wrapper that names no MEOS call of its own passes the call info to a shared helper and binds the rest there:
Tjsonb_object_fieldisTjsonb_object_field_common(fcinfo, false)over a helper that callstjsonb_object_field(temp, key, astext, null_handle). The pass follows that hop, matching the literals to the helper's parameters by position, so an argument of the MEOS call naming one of them resolves to the literal behind it. Each catalog entry names one wrapper, so the sibling binding the opposite literal is a separate entry and the two stay distinct. Over MobilityDB master the bound-literal count reads 153, and every literal the pass already captured keeps its value.