Write the interpolation the standard names - #58
Merged
Conversation
A temporal geometry and a temporal property value carry `Step` for the step function, which is what OGC API - Moving Features Part 1 names in each of the two places it constrains an interpolation: `motionCurve`, which a temporal geometry takes through a `$ref`, enumerates Discrete/Step/Linear/Quadratic/Cubic, and `temporalPrimitiveValue` enumerates Discrete/Step/Linear/Regression. The word `Stepwise` belongs to the older MF-JSON encoding extension and appears nowhere in Part 1, so the response carries MobilityDB's own `Step` rather than rewriting it; a client that writes `Stepwise` is still understood, alongside `Step`. A test reads both admitted sets out of the vendored schema and checks the token each document carries, and the two samples holding a step interpolation carry `Step`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A temporal geometry and a temporal property value carry
Stepfor the step function, which is what OGC API - Moving Features Part 1 names in each of the two places it constrains an interpolation:motionCurve, whichtemporalPrimitiveGeometry.interpolationtakes through a$refDiscrete, Step, Linear, Quadratic, Cubic(or a URI)temporalPrimitiveValue.interpolationDiscrete, Step, Linear, RegressionStepwisebelongs to the older MF-JSON encoding extension and occurs 0 times in Part 1, against 7 forStep; the standard's own examples write"discharge": "Step". The response therefore carries MobilityDB's ownStep, which is already that token, rather than rewriting it. A client that writesStepwiseis still understood, alongsideStep.A test reads both admitted sets out of the vendored schema — they are not the same list, and the geometry one is reachable only through the
$ref— and checks the token each document carries.TestATSSchemaMotionCurveIsInvertedalready quotes that same enum, so the rewrite contradicted a test in the tree.The two sample documents holding a step interpolation carry
Step.