Measure the standard's examples against the standard's schemas - #59
Merged
Conversation
Every example the OGC document publishes sits in a media-type object beside the schema it illustrates, so the pairing is the document's own and the test chooses nothing. 10 of the 16 examples paired with a named schema do not satisfy it, and `TestATSSchemaPublishedExamples` asserts that count the way the nullable-rewrite count is asserted, so a change in the vendored document is noticed rather than absorbed; a seventeenth example is attached to an inline schema and is not compared. The failures concentrate in two cells no document can meet — `temporalPrimitiveValue.values` is a single scalar beside a `datetimes` array of `minItems: 2`, and `temporalProperty` carries that value object — so the count measures the standard against itself, the examples being what a reader would write. `openapi/README.md` carries the figure and the reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every example the OGC document publishes sits in a media-type object beside the schema it illustrates, so the pairing is the document's own and the test chooses nothing.
10 of the 16 examples paired with a named schema do not satisfy it.
TestATSSchemaPublishedExamplesasserts that count the way the nullable-rewrite count is asserted, so a change in the vendored document is noticed rather than absorbed; the per-example reasons are in its log. A seventeenth example is attached to an inline schema and is not compared.The failures concentrate in two cells no document can meet:
temporalPrimitiveValue.valuesis a single scalar beside adatetimesarray ofminItems: 2, andtemporalPropertycarries that value object. So the count measures the standard against itself — the examples are what a reader would write, and the schemas are what rejects them.openapi/README.mdcarries the figure and the reason beside the two gaps it already records.