Accept only the interpolations the standard names - #60
Merged
Conversation
The interpolation a client may write is the set OGC API - Moving Features Part 1 names: a temporal geometry takes Discrete, Step, Linear, Quadratic or Cubic through `motionCurve`, and a temporal property value takes Discrete, Step, Linear or Regression through `temporalPrimitiveValue`. `Stepwise` is the older MF-JSON encoding extension's word for the step function, Part 1 does not name it, and the tier no longer answers to it. A name outside the set is refused where it is read rather than carried into MobilityDB to fail there, and the two refusals are different answers: a name the standard admits and MobilityDB does not carry — Quadratic, Cubic, Regression — is 501, because the request is understood and unserved, while a name the standard does not admit at all is 400. The status travels with the error, so a temporal property POST reports the one its body earns.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The interpolation a client may write is the set OGC API - Moving Features Part 1 names:
motionCurveDiscrete, Step, Linear, Quadratic, CubictemporalPrimitiveValueDiscrete, Step, Linear, RegressionStepwiseis the older MF-JSON encoding extension's word for the step function. Part 1 does not name it, so it is not a name a conformant client writes and the tier does not answer to it.A name outside the set is refused where it is read, rather than carried into MobilityDB to fail there, and the two refusals are different answers a client can act on:
Quadratic,CubicandRegression— the standard names them and MobilityDB does not carry them, so the request is understood and unserved;Stepwiseamong them.The status travels with the error, so a temporal property POST reports the one its body earns. The output side is untouched — the tier writes
Step— and the sample documents are identical, which the conformance job's freshness check confirms.