Measure the published examples under both readings of format - #61
Merged
Conversation
The count of examples that fail the schema they are published under depends on how a validator treats `format`, and both readings are asserted: 10 of the 16 examples paired with a named schema fail with `format` asserted, and 13 of 16 fail at JSON Schema's default, where `format` is an annotation. The difference is the inverted `oneOf` of `motionCurve` acting on the standard's own material — at the default reading its URI branch reduces to "any string", both branches match a named value, and `oneOf` rejects the vocabulary the standard defines. `LandingPage` and `Conformance` declare a schema and publish no example, so the test counts them apart from the examples it validates: a row with nothing to validate is not a row that passes, and counting it among the passes makes a tally read better than the material it is taken over.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The count of examples that fail the schema they are published under depends on how a validator treats
format, so both readings are asserted:formatThe difference between them is the inverted
oneOfofmotionCurveacting on the standard's own material: at the default reading its URI branch reduces to "any string", both branches match a named value, andoneOfrejects the vocabulary the standard itself defines. Asserting one count alone states a number whose meaning depends on a setting the reader cannot see.LandingPageandConformancedeclare a schema and publish no example, and the test counts them apart from the examples it validates. A row with nothing to validate is not a row that passes, and counting it among the passes makes a tally read better than the material it is taken over.openapi/README.mdcarries both figures and the two exampleless responses.