Process the subTemporalValue parameter - #62
Merged
Conversation
`subTemporalValue` selects the subsequence of a temporal property clipped to the datetime interval, which is what Part 1 states it does: under the flag the datetime parameter is a bounded interval and `leaf` is not used. A request carrying the flag without a bounded interval is refused, and one carrying `leaf` beside it is answered on the interval; both spellings of the name are read, as the temporal-geometry side already reads both spellings of `subTrajectory`. The flag governs the route that returns values. The temporal-properties listing answers a document carrying each property's name, type, unit and links and no valueSequence — which `temporalProperty` makes optional — so a flag that clips values has nothing to clip there, and that route no longer advertises one. `TestATSLiveSubTemporalValue` discharges /conf/movingfeatures/param-subtemporalvalue-response against the fixture, and asserts that the answer moves: the clipped property holds strictly fewer instants than the unclipped one and none outside the interval, since a parameter that is read and changes nothing a client receives cannot be told from one that is ignored.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
subTemporalValueselects the subsequence of a temporal property clipped to the datetime interval, which is what Part 1 states it does: under the flag the datetime parameter is a bounded interval andleafis not used. A request carrying the flag without a bounded interval is refused with 400, and one carryingleafbeside it is answered on the interval. Both spellings of the name are read, as the temporal-geometry side reads both spellings ofsubTrajectory.The flag governs the route that returns values. The temporal-properties listing answers a document carrying each property's name, type, unit and links and no
valueSequence— whichtemporalPropertymakes optional — so a flag that clips values has nothing to clip there, and that route advertises none.TestATSLiveSubTemporalValuedischarges/conf/movingfeatures/param-subtemporalvalue-responseagainst the fixture, and asserts that the answer moves: the clipped property holds strictly fewer instants than the unclipped one and none outside the interval. A parameter that is read and changes nothing a client receives cannot be told from one that is ignored.samples/api-definition.jsonrecords the service description this tier publishes, so the sample set carries the parameter list as it stands.