Name the S2 cell family the gate cannot otherwise see - #349
Merged
estebanzimanyi merged 1 commit intoAug 28, 2026
Merged
Conversation
The family gate rejects a function by the family tokens of its NAME, and it can only reject a token it knows. The S2 cell index family is absent from that vocabulary, so tbigint_to_ts2cell reads as a tbigint function — its other token is a registered family — and passes. What passes is emitted: a call to a MEOS symbol no included header declares, which the extension fails to compile, and a registration of ts2cell(tbigint) returning tbigint, the operand type standing in for the one the generator has no accessor to name. ts2cell and s2cell join KNOWN_FAMILIES and not REGISTERED_FAMILIES, the pair that states a family MobilityDB publishes and the binding does not register yet, so supported() answers unregistered-family:ts2cell for both conversions while the registered tbigint_to_tquadbin sibling stays emittable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The family gate rejects a function by the family tokens of its NAME, and it can only reject a token it knows. The S2 cell index family is absent from that vocabulary, so tbigint_to_ts2cell reads as a tbigint function — its other token is a registered family — and passes. What passes is emitted: a call to a MEOS symbol no included header declares, which the extension fails to compile (run 33166334744), and a registration of ts2cell(tbigint) returning tbigint, the operand type standing in for the one the generator has no accessor to name. ts2cell and s2cell join KNOWN_FAMILIES and not REGISTERED_FAMILIES, the pair that states a family MobilityDB publishes and the binding does not register yet, so supported() answers unregistered-family:ts2cell for both conversions while the registered tbigint_to_tquadbin sibling stays emittable. raquet stays out of the pair: src/raster/raquet.cpp registers that type, so naming it would reject functions that build today.