Name the GiST translate-cmptype support function as PostgreSQL 18 defines it - #33
Merged
estebanzimanyi merged 1 commit intoAug 28, 2026
Conversation
…ines it PostgreSQL 18 declares the default translate-cmptype support function as gist_translate_cmptype_common in utils/fmgrprotos.h, which mgistutil.c already includes, so the definition it carries takes that name and draws its prototype from the server header the way every other core-named function in the file does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PostgreSQL 18 declares the default translate-cmptype support function as
gist_translate_cmptype_commoninutils/fmgrprotos.h, whichmgistutil.calready includes, so the definition it carries takes that name and draws its prototype from the server header the way every other core-named function in the file does — the thirteen copied alongside it read theirs fromaccess/gist_private.handgisttranslatecmptypereads its fromaccess/gist.h. Building against PostgreSQL 18.3 goes from one-Wmissing-prototypeswarning to none, and the support function number the opclasses use is unchanged.