Repository navigation
fix(bangumi): 同步不再把整部标成看过,推未标单集时恢复在看 - #101
Merged
Merged
Conversation
- 去掉按本地已看集数判定整部完成度的逻辑,同步不再写「看过」 - 只在真的推送单集时动整部:未收藏/想看 -> 在看;线上已看过但该集未标 -> 恢复在看 - 无可推单集时不再写收藏,避免无变化也刷新收藏更新时间 - 播放完即时上报同样处理,重看已标过的集不动整部
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
Bangumi 同步在推送单集之后,会按「本地已看的集数 ≥ 本地库里的集数」把整部收藏写成「看过」(
upsertSubjectCollection(type=2))。本地库只有部分集(当季只更新了前几集,或只下了前几集)时,只要这几集看完,整部就会被标成「看过」;点一次「同步全部」,库里每一部都会被这样写一遍。
改动
upsertSubjectCollection,避免无变化也刷新收藏更新时间markEpisodeWatched)同样处理;该集线上已标过(重看)时不动整部测试
:sync-engine-shared:test全绿