Skip to content

feat(release): publish daily pinnable edge builds and stamp and attest every release - #1031

Merged
ragnorc merged 6 commits into
ModernRelay:mainfrom
ragnorc:edge-releases-daily
Oct 17, 2026
Merged

ragnorc merged 6 commits into
ModernRelay:mainfrom
ragnorc:edge-releases-daily

Conversation

@ragnorc

@ragnorc ragnorc commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Why

Edge releases were hard to deploy safely:

  • The rolling edge tag moved before anything was built, and each platform build published itself. For up to an hour, the release named the new commit while some archives were still the previous build's. A failed platform build kept its old binary under the new label.
  • A deployment couldn't pin or roll back an edge build, because the next merge overwrote it. versioning.md says to export a graph at an abandoned development format "with the build that wrote it", which the rolling tag made impossible.
  • An edge binary printed 0.14.0, the same as the coming release, and didn't say which commit it was built from.
  • Nothing told a deployer that the first write from an edge build stamps a branch with storage format 16, which v0.13.0 refuses to open.

What changes

  • Daily, pinnable edge builds. release-edge.yml runs once a day (04:17 UTC) and on manual dispatch on main, instead of being called by every main CI run. It builds the run's own commit, the tip of main, unless edge already holds it, and refuses before building while the package version is not above the latest stable release (X.Y.Z-edge+<commit> sorts before X.Y.Z). The shared gate gains wait_minutes, require_ci_gate and superseded_ok: the edge run waits up to 180 minutes for that commit's CI run, which may be queued behind earlier runs on main, to pass both the vocabulary audit and CI Gate. A run cancelled because main moved on ends with a notice and no build. A run builds only its own commit because the provenance names that commit (see the review section). Each build becomes its own prerelease, edge-<commit date>-<short commit>, which never changes once published. The rolling edge release copies that release's archives, moves only forward along main, and drops files that aren't in the build (which removes the stale omnigraph-macos-x86_64.*). The 30 newest builds are kept, plus the newest build of each storage format, which a marker line in the release text records (scripts/edge_release.py prune).
  • One build definition. New build-release-archives.yml, called by both release.yml and release-edge.yml. It builds the four archives, runs each on its own platform, and verifies the exact set and checksums. It writes no release; each caller's single publisher does.
  • Build identity. Archives are compiled with OMNIGRAPH_SOURCE_VERSION and OMNIGRAPH_RELEASE_CHANNEL. One module, omnigraph_api_types::build, reads both, refuses a malformed stamp at compile time and derives the reported version. omnigraph version prints a commit line, and --json adds channel and commit. An edge build reports 0.14.0-edge+9c2b367, as do /healthz version and the MCP server info; source_version names the commit.
  • Release text for deployers. scripts/edge_release.py body (tested by scripts/test_edge_release.py; CI also runs it on the real release-note preview) writes each edge release's text from facts: the build's own omnigraph version --json next to the latest stable release's, with install-by-tag commands, then the release_notes.py preview notes since the last stable release. It warns when a stable binary could not open a branch the build writes to.
  • Provenance and smoke tests. Both publishers attest their archives with actions/attest-build-provenance, and the tag-release caller in CI gains id-token: write and attestations: write. The predicate names the run's commit (the OIDC sha claim), so both publishers refuse to attest a build of any other commit. A stable backfill from v0.14.0 must be dispatched at the tag itself (gh workflow run release.yml --ref <tag> -f tag=<tag>); an older tag backfilled from elsewhere publishes without provenance. Installer smoke tests run on all four platforms instead of only Windows. A manual backfill of a tag before v0.14.0 builds a source without the stamp, so its archives are run but their stamp is not checked.
  • Container image. publish-image.yml passes the same stamps (stable) into its bookworm build and checks them in the image with omnigraph version --json before pushing. It attests the pushed GHCR digest (push-to-registry) under the same rule as the archives: only for the run's own commit, and from v0.14.0 a backfill is dispatched at its tag. Docker Hub gets the same image but no attestation of its own. Homebrew already uses the stamped, attested stable archives; crates.io (paused) and install-source.sh are source builds and stay unstamped.
  • scripts/check-release-vocabulary-gates.py now pins the scheduled publisher, the forward-only rolling tag, the audited walk-back and the shared build. Docs: install.md (channels, pinning, the storage warning, verify), ci.md, documentation.md, branch-protection.md, and two changelog.d notes.

Testing

  • actionlint with shellcheck on every workflow; check-release-vocabulary-gates.py (also refused deliberately broken copies), check-workflow-action-pins.py, check-merge-group-triggers.py, ci_gate.py --self-test, check-change-classes.py, check-docs.py, check-agents-md.sh, release_notes.py preview --working-tree, typos, cargo fmt --all --check.
  • scripts/test_edge_release.py (15 tests: release text, version order, the build marker and the retention plan), and the composer run against the real notes since v0.13.0 (69 KB, under GitHub's 125,000-character limit). The retention plan was also run on this repository's real releases.
  • The gate's job check against real main runs: run 38976487632 (all green) passes with and without require_ci_gate; run 38055777855 (vocabulary guard success, CI Gate failure) passes without it and is refused with it. The superseded condition holds for cancelled run 38870718075 and not for 38976487632.
  • omnigraph-api-types identity tests and auth_policy::healthz_succeeds_after_startup pass unstamped and stamped as edge; a seven-character commit fails to compile omnigraph-api-types.
  • CLI: output::tests::edge_builds_report_a_prerelease_naming_their_commit, output::tests::build_stamps_accept_only_full_commits_and_known_channels and cli_schema_config::version_command_prints_cli_version_http_contract_and_storage_formats_issue_977 pass both unstamped and with OMNIGRAPH_RELEASE_CHANNEL=edge OMNIGRAPH_SOURCE_VERSION=<commit>. The stamped binary prints omnigraph 0.14.0-edge+a60b822, internal-schema 16 (serves v14 to v16), http-contract 0.13 and commit a60b8226…. A seven-character commit and the channel nightly each fail to compile with the intended message. Clippy was not run locally; CI runs it.
  • The shell logic for naming, the latest-stable lookup and forward-only ancestry, run read-only against this repository's real tags and history.

Not tested: the workflows themselves, which only run after merge. The first scheduled run will be the first live test of draft-then-publish, the in-place edge update, pruning and attestation.

Review

A Codex review (gpt-6-astra) of the first commit found one P1: the provenance action takes its source commit from the OIDC sha claim, not from the checkout (confirmed in actions/toolkit packages/attest/src/provenance.ts). A daily run that walked back to an older audited commit, or a stable backfill dispatched from main, would have signed provenance naming the wrong commit. The second commit fixes it as described above. For the automatic tag path, the run's commit is the tagged commit even for annotated tags: the v0.13.0 tag push ran at 926ba352.

A second review of the whole PR found one P2: an overlapping manual and scheduled run could move edge between one run's publication and its rolling-channel installer checks, failing a successful release. The edge workflow now serializes whole runs with workflow-level concurrency instead of locking only the publish job.

A cursor[bot] review requested one change and recommended five more, all made in 76324cf5: the version-order check; CI Gate required for edge; the superseded run ending quietly; per-format retention; the shared build-identity module; and the composer CI step. The two copies of the v0.14.0 cutoff are now held to one value by the gate checker.

Notes for review

  • The first scheduled run deletes omnigraph-macos-x86_64.* (last updated 2026-04-26) from the public edge release.
  • While edge updates, gh release upload --clobber deletes the old files before uploading the new ones. For the length of the upload, the edge channel returns 404 (fails closed), once a day.
  • The stamp cutoff in release.yml assumes v0.14.0 is the first tag that contains this change.
  • The first edge run after merge can only build a commit that contains the new workflow; until then the existing edge stays as it is.
  • The rolling edge release is updated in place. GitHub's immutable-releases setting (off on this repository) would refuse that, prereleases included; the per-build releases would keep working.
  • Publishing pushes each build's tag itself before publishing its draft, so it doesn't depend on GitHub creating the tag when a draft is published, which the REST docs don't state.
  • No backing issue exists for this change.

Edge releases now build once a day from the newest audited commit on main
and publish each build as its own prerelease, edge-<commit date>-<short
commit>, which never changes once published; the rolling edge release copies
it and only moves forward. Both release workflows share one archive build
that stamps the commit and channel into the binaries, runs each archive on
its platform and verifies the exact set, and both attest build provenance.
Each edge release states its storage format and HTTP contract next to the
latest stable release's, then the notes recorded since that release.
@ragnorc
ragnorc requested a review from aaltshuler as a code owner October 16, 2026 23:27
The provenance predicate takes its source commit from the run's OIDC sha
claim, not from the checkout. An edge run now builds only its own commit,
waiting up to 90 minutes for that commit's audit instead of walking back to
an older one, and both publishers refuse to attest a build of any other
commit; a stable backfill from v0.14.0 is dispatched at its tag.
A newer edge run could move the rolling tag after an older run published
but before its installer checks ran, failing a release that succeeded.
Whole runs now share one concurrency group.
The image's bookworm-built binaries now carry the same commit and stable
channel stamp as the release archives, checked inside the image before it is
pushed, and the pushed GHCR digest carries a build provenance attestation
under the same rule: only for the run's own commit, and from v0.14.0 a
backfill is dispatched at its tag.
@ragnorc ragnorc changed the title feat(release): publish daily, pinnable and attested edge builds feat(release): publish daily pinnable edge builds and stamp and attest every release Oct 16, 2026
Comment thread crates/omnigraph-cli/src/output.rs Resolved
Comment thread .github/workflows/release-edge.yml Resolved
Comment thread crates/omnigraph-cli/src/output.rs Resolved
Comment thread .github/workflows/release-edge.yml Resolved
Comment thread scripts/edge_release.py Resolved
@cursor

cursor Bot commented Oct 17, 2026

Copy link
Copy Markdown

Review of 71e43622ac6518fa4df1fcff04456af3d83d85f6

Recommendation: request changes. There is one small blocking item, a version-ordering claim. The other findings are optional. The design is sound, and the code is correct for everything I could run before merge.

Why, what, how, impact

  • Why. Edge builds were not safe to deploy. The edge tag moved before the build. Each platform published alone, so for up to an hour the release named a new commit while some archives were older. (The current edge assets were uploaded between 22:59 and 23:43 UTC on 2026-10-16, and one asset is from 2026-04-26.) A deployer could not pin a build, and a binary did not name its commit.
  • What. A daily scheduled publisher. One shared archive build (build-release-archives.yml) for stable and edge. Each edge build becomes an immutable prerelease edge-<commit date>-<sha7>, which is then copied to edge, forward-only. The CLI gets compile-time commit and channel stamps. Archives and the GHCR image get provenance attestations. The edge release text comes from the binaries' own version facts.
  • How. One writer job for each release. A draft that becomes visible only after every archive is attached. A GITHUB_SHA == SOURCE_SHA check before each attestation. Const assertions that refuse a malformed stamp.
  • Impact. Deployers get pinnable, attested edge builds and a storage-format warning. Stable releases get provenance and installer smoke tests on all four platforms. Operators must dispatch a stable backfill from v0.14.0 at the tag itself.

Blocking

  1. The edge version does not always sort before the newer release. 0.X.Y-edge+sha ranks below 0.X.Y in the window after a stable tag and before main bumps its version. The last cycle had a 7-day window (v0.13.0 on 2026-10-07, bump in release: bump development version to 0.14.0 #998 on 2026-10-14). The code comment, install.md and the changelog all make this claim. Fix it in the edge publisher, or narrow the claim in the text. Details are in the inline comment on crates/omnigraph-cli/src/output.rs:1124.

Optional (recommended first)

  1. Count-only retention can delete the only build that can export an abandoned development format. Keep the newest build for each format it writes. (release-edge.yml:292)
  2. The gate admits commits whose tests failed. Those commits now become pinnable, attested releases. Require CI Gate or say this in the docs. (release-edge.yml:86)
  3. A superseded or slow tip CI run makes the daily run red, but no action is needed. (release-vocabulary-gate.yml:117)
  4. Build identity has two derivations: the CLI reports 0.14.0-edge+…, but /healthz and MCP still report 0.14.0. Use one module that both binaries share. (output.rs:1125)
  5. The composer parses rendered Markdown that feat(release-notes): format-2 release pages and a release-note check #880 rewrites. Add a CI step that pipes the real preview into the composer. (scripts/edge_release_body.py:131)

What I checked and found correct

  • Freshness, naming and forward-only logic. I ran it read-only against live refs: main = 0b5e17f, edge = 450f774 (a lightweight tag). The result was publish=true, forward move allowed, tag edge-20261016-0b5e17f.
  • A rerun keeps the first published archives. Old drafts are removed before the by-tag lookup. A mismatched existing tag fails closed. Workflow-level concurrency serializes whole runs, so the rolling-channel smoke tests check this run's build.
  • scripts/install.sh and install.ps1 accept any tag, so VERSION=edge-… works. The real v0.13.0 binary's text version output parses through parse_facts.
  • Permissions are least-privilege for each job. The CI caller adds id-token/attestations: write only to the tag publishers. build-release-archives.yml cannot write.
  • The CodeBuild packager passes a full git rev-parse HEAD, so the new compile-time check does not break it.
  • Scope. There is no storage, format or Lance API change, so the Lance alignment domains do not apply. GQT is not suitable, because the contract here is CLI binary metadata, not query rows. The PR extends the existing owner, the CLI: omnigraph version --json reporting the HTTP contract and storage versions #977 version test, which is the right tier.

Liability

  • Removed: two copies of the archive matrix (now one); the window where edge named a commit that its archives did not contain; per-platform publication.
  • Added: a scheduled publisher with its own state machine (draft cleanup, rolling copy, prune); a Python composer coupled to the release-note renderer; and the v0.14.0 stamp cutoff written twice, in Python in release.yml and in bash in publish-image.yml. The cutoff can be removed when pre-0.14 backfills stop mattering. Until then, one shared helper would keep the two copies from drifting.
  • Five more changes like this: each new artifact (admission wrapper output, an edge image, MCP) would copy the stamp logic unless identity moves into one crate (finding 5). The shared build workflow already prevents the same problem for archives.

Validation

Reviewed head 71e43622. Before-fix base 0b5e17fa (merge base, main at review time). All runs were in a clean, isolated worktree.

Command (local) Result
cargo test -p omnigraph-cli --locked --bin omnigraph output::tests:: (unstamped, and with OMNIGRAPH_RELEASE_CHANNEL=edge OMNIGRAPH_SOURCE_VERSION=71e43622…) 9 passed, both times
cargo test -p omnigraph-cli --locked --test integration cli_schema_config::version_command (unstamped and stamped) 1 passed, both times
Same test on base 0b5e17fa with only the PR's cli_schema_config.rs FAILED for the predicted reason: unstamped JSON lacks channel/commit; stamped output prints omnigraph 0.14.0 and no commit line. Temporary edit restored.
Stamped omnigraph version / --json / --version omnigraph 0.14.0-edge+71e4362, commit 71e43622…, JSON channel: "edge"
Build with SOURCE_VERSION=71e4362, with channel nightly, and with channel and no commit Each refused at compile time (E0080) with the intended message
cargo test -p omnigraph-server --locked --test integration auth_policy::healthz_succeeds_after_startup (stamped) 1 passed
python3 scripts/test_edge_release_body.py 9 OK
release_notes.py preview --target 71e43622 → edge_release_body.py (build and rolling) exit 0; 69,197 and 69,391 bytes
check-release-vocabulary-gates.py OK. It refuses a copy without run-level concurrency and without the forward-only check.
actionlint 1.7.12 with shellcheck on the six changed workflows no findings
check-workflow-action-pins.py, check-merge-group-triggers.py --self-test, ci_gate.py --self-test, check-change-classes.py, check-docs.py, check-agents-md.sh, cargo fmt --all --check pass

CI at the exact head: every check succeeded, including Test Workspace, Lint (clippy), GQ Logic Tests, DST pinned suite and CI Gate. Graph Vocabulary Guard and the tag publishers were skipped, as expected for a PR event.

Limits. I did not run Clippy locally (CI did). The workflows themselves cannot run before merge. The GitHub behaviors (draft-by-tag resolution, the --clobber 404 window, OIDC sha in the provenance predicate, gh attestation verify on the copied edge archives) come from code reading, not from execution. The cancelled-run and CI-duration figures come from the last 100 main push runs. I make no performance claims.

- Refuse an edge build while the package version is not above the latest
  stable release: X.Y.Z-edge+<commit> sorts before X.Y.Z, so the ordering
  claim held only after main advanced its version.
- Require the commit's CI Gate as well as its vocabulary audit, waiting up to
  180 minutes, since the build becomes a pinnable, attested release; a run
  cancelled because main moved on now ends the edge run with a notice.
- Keep the newest edge build of every storage format beyond the retained 30,
  read from a marker line in the release text, so the build that can export
  an abandoned development format survives.
- Report one build identity from omnigraph-api-types: the CLI, /healthz and
  the MCP server info share the stamped version and its compile-time checks.
- Compose the edge release text from the real release-note preview in CI, and
  hold the two copies of the v0.14.0 attestation cutoff to one value.
@ragnorc

ragnorc commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor Author

All six findings are addressed in 76324cf; replies are inline. On the liability note about the v0.14.0 cutoff: a shared helper script would not reach backfills of old tags, because those check out the tag's own tree. Instead, check-release-vocabulary-gates.py now requires the Python cutoff in release.yml and the bash cutoff in publish-image.yml to name the same version.

🤖 Addressed by Claude Code

@ragnorc
ragnorc enabled auto-merge October 17, 2026 05:41
@ragnorc
ragnorc added this pull request to the merge queue Oct 17, 2026
Merged via the queue into ModernRelay:main with commit 4d7536d Oct 17, 2026
34 checks passed
ragnorc added a commit to ragnorc/omnigraph that referenced this pull request Oct 18, 2026
ModernRelay#1036)

* fix(cleanup): finish a table whose interrupted sweep removed its index directory

The collector deletes a swept version's files before its manifest, so a
pass that stops in between leaves the manifest for the next pass. On a
local store that next pass failed for the table: `delete_paths` called
`remove_dir_all` again on the `_indices/<uuid>` directory the stopped pass
had removed, and Lance's local provider reports an absent directory as
`NotFound`. The table kept the error and deleted nothing on every later
run. Object stores list the prefix empty and succeed, so S3, Azure and
the DST memory store converged already.

An absent index directory is now already deleted, as an absent file
already was. The files-before-manifest order is unchanged, and the
deletion set still holds only paths no retained root marks.

The failpoints test stops a pass at `cleanup.sweep_pre_manifest_delete`
after it removed an index directory only the pruned pin names, then
proves the next pass removes that manifest, reports no error, and leaves
every retained root's paths in place.

* docs(cleanup): state the sweep order before the retry outcome

Reword the maintenance guide's sentence on an interrupted cleanup so the
deletion order and the next run's outcome read as two steps, and point
the release note at the guide's Cleanup section.

* test(cleanup): interrupt the sweep between manifests and before dead-staging manifests

Cover the directory-touching windows of the collector's sweep on a local
store, where Lance reports removing an absent directory as NotFound:

- a pass stopped between two manifests of the published sweep, with an
  index directory among the files it already deleted;
- a pass stopped after the dead stagings' files and before their
  manifests, through the new seam cleanup.sweep_pre_dead_manifest_delete.

Each retry reports no error, removes the remaining manifests and keeps
every retained root's paths.

* test(cleanup): run the sweep crash windows on S3 and Azure

The three collector-retry fixtures in failpoints.rs become helpers over a
graph uri. The file tests keep their names and call them on a temporary
directory; one RustFS/S3 test and one Azure/Azurite test run all three, each
on a fresh graph root, and both CI jobs require them by name.

The first fixture now also stops a pass at cleanup.sweep_pre_file_delete,
the one sweep window no failpoint test reached: the pass deletes nothing
and the next pass plans the same sweep. Its retry asserts what the other two
already did, no error on any table and nothing left to remove.

Index-directory presence goes through the storage adapter's exists rather
than std::fs, so the same assertion holds on an object store. The RFC's
crash-window gate is satisfied and leaves blocked_on; the evidence bullet
names the owners per backend.

* test(dst): reach the dead-staging sweep window

Register cleanup.sweep_pre_dead_manifest_delete in the crash-window
catalog (appended, 53 windows) and give it a milestone recipe: insert,
index build, insert, cleanup. The reach census's setup crash stops the
index build before its manifest commit, stranding a detached staging; the
second insert moves main's head past the head the staging recorded, so
the recipe's cleanup judges it dead and crosses the window.

A window inside cleanup's per-table pass does not fail the op: cleanup
records the table's error and returns Ok. The harness treated that as a
plain success, so no retry was judged and the report kept no trace of
the window. crash_op now returns CleanupDeferred when the op's deferrals
name the scheduled window; the universe records deferred:<window>@op<i>
and runs the obligation pass a crashed cleanup gets (a clean rerun that
defers nothing, the collector oracle, the world read). This covers
cleanup.table_gc and the three earlier sweep windows as well.

The pin dst_dead_staging_sweep_window_is_reached_and_retried probes the
window and stops the recipe's cleanup at it; the sensitivity proof gains
a deferred-cleanup case. Both go red with the routing reverted.

* test(dst): schedule setup crashes in the hunt and the fleet

cleanup.sweep_pre_dead_manifest_delete needs an earlier crash's
aftermath: an index build stopped before its manifest commit. Only the
reach census added that crash, by spending the universe's one
crash_on_match slot on it, so the hunt and the fleet scheduled the window
on a cleanup with no dead staging and it never fired there.

Scenario::setup_crash is a second slot, matched before crash_on_match and
always a real crash, even under probe_only; crash_on_match starts matching
after it. harness::setup_crash_for replaces the test-only census_setup
and keeps only its live entry; window_needs_wide and
window_needs_schema_ops include the setup's needs. The reach census, the
hunt and the fleet's window arm take the setup from it, and the hunt
counts a hit from the window's own verdict instead of crashes > 0, which
a setup crash alone would satisfy. The pin now stops the cleanup through
the fleet arm's scenario instead of a pinned op index.

* feat(release): publish daily pinnable edge builds and stamp and attest every release (ModernRelay#1031)

* feat(release): publish daily, pinnable and attested edge builds

Edge releases now build once a day from the newest audited commit on main
and publish each build as its own prerelease, edge-<commit date>-<short
commit>, which never changes once published; the rolling edge release copies
it and only moves forward. Both release workflows share one archive build
that stamps the commit and channel into the binaries, runs each archive on
its platform and verifies the exact set, and both attest build provenance.
Each edge release states its storage format and HTTP contract next to the
latest stable release's, then the notes recorded since that release.

* fix(release): attest only the commit a release run is for

The provenance predicate takes its source commit from the run's OIDC sha
claim, not from the checkout. An edge run now builds only its own commit,
waiting up to 90 minutes for that commit's audit instead of walking back to
an older one, and both publishers refuse to attest a build of any other
commit; a stable backfill from v0.14.0 is dispatched at its tag.

* fix(release): keep edge runs from overlapping

A newer edge run could move the rolling tag after an older run published
but before its installer checks ran, failing a release that succeeded.
Whole runs now share one concurrency group.

* feat(release): stamp and attest the container image

The image's bookworm-built binaries now carry the same commit and stable
channel stamp as the release archives, checked inside the image before it is
pushed, and the pushed GHCR digest carries a build provenance attestation
under the same rule: only for the run's own commit, and from v0.14.0 a
backfill is dispatched at its tag.

* fix(release): address review of the edge release rework

- Refuse an edge build while the package version is not above the latest
  stable release: X.Y.Z-edge+<commit> sorts before X.Y.Z, so the ordering
  claim held only after main advanced its version.
- Require the commit's CI Gate as well as its vocabulary audit, waiting up to
  180 minutes, since the build becomes a pinnable, attested release; a run
  cancelled because main moved on now ends the edge run with a notice.
- Keep the newest edge build of every storage format beyond the retained 30,
  read from a marker line in the release text, so the build that can export
  an abandoned development format survives.
- Report one build identity from omnigraph-api-types: the CLI, /healthz and
  the MCP server info share the stamped version and its compile-time checks.
- Compose the edge release text from the real release-note preview in CI, and
  hold the two copies of the v0.14.0 attestation cutoff to one value.

* feat(load): plan CSV overwrites and reuse validation reads (ModernRelay#1026)

* fix(cli): accept --as on commit publish and drop (ModernRelay#1029)

* fix(cli): accept --as on commit publish and drop

The plane guard classified every `commit` subcommand as a read and refused
`--as`, so `commit publish` and `commit drop` against a direct graph could
only attribute `operator.actor`, although both dispatch through the write
resolver and the engine's `_as` entry points. The guard now matches the
`commit` subcommands exhaustively: publish and drop take `--as` on a direct
target, while list, show and changes still refuse it. A served publish or
drop still refuses `--as` before any request. Guard errors name the
subcommand (`commit list`, ...).

The published commit keeps the actor of the write that created it; the
branching guide now says so.

* test(cli): pin created_at and fold the served refusal into its owner

The publish regression now also checks that the published commit keeps
the proposal's `created_at`, the second half of the branching guide's
claim. The served `--as` refusal for `commit publish` and `commit drop`
moves into `as_on_a_served_write_is_rejected` as two more argument rows
instead of a parallel fixture. Rewrap the edited guide paragraph.

* docs(changelog): say a published commit keeps its timestamp too

The branching guide and the regression test state both the actor and the timestamp; the release note now says the same.

* fix(cli)!: send a server token only to the server it is keyed to (ModernRelay#1030)

* refactor(cli): centralize invocation and command boundaries (ModernRelay#1047)

* refactor(cli): capture operator config during client setup

* refactor(cli): reuse config for aliases and served clusters

* refactor(cli): isolate invocation parsing

* refactor(cli): make scope resolution pure

* refactor(cli): separate application completion from process exit

* refactor(cli): extract query family and typed preparation

* refactor(cli): capture presentation and preserve delivery outcomes

* test(cli): qualify captured presentation across execution

* refactor(cli): isolate graph history execution and output

* fix(cli): track dedicated commit write outcomes

* docs(cli): describe history delivery and outcome boundaries

* refactor(cli): isolate transfer execution and delivery

* refactor(cli): isolate schema lifecycle and lint execution

* refactor(cli): isolate maintenance execution and delivery

* refactor(cli): isolate cluster control execution and delivery

* refactor(cli): complete invocation config and I/O boundaries

* fix(cli): preserve failures and recovery across output errors

* docs(cli): consolidate server credential guidance

* feat(commits): page a branch's commit list (ModernRelay#1013)

* feat(commits): page a branch's commit list

GET /commits returned a branch's whole lineage, and building it read all of
__history. It now takes `limit` (1 to 1,000) and an opaque `page_token`;
a paged answer names `head_commit_id`, the head its first page resolved,
and a `next_page_token` while older commits remain. Later pages answer
for that head's first-parent chain even after the branch moves, and the
token carries a digest of the branch, never its name. Without either
parameter the answer is unchanged.

A page walks first parents by falling generation from the head or the
token's next commit: the head and buffer cost nothing, and an older commit
is read by id with the rest of its __history extent, so a page costs the
extents its own commits occupy and never the history below them.

`omnigraph commit list --limit/--page-token` and the MCP `commits_list`
tool page the same way.

* test(commits): register the paged commit list as a read-only surface

The public and coordinator API registries in forbidden_apis classify every
async entry point; Omnigraph::list_commits_page and
GraphCoordinator::first_parent_page read and publish nothing.

* test(commits): track the reworded commit list description in the vocabulary inventory

The listCommits description still names the graph-manifest version in its
ordering sentence; its prose digest changed with the paging text.

* test(commits): pin commit-list page storage calls in the DST cost golden

The newest and the oldest page of main's commit list on a reopened handle,
after 12 and 36 publishes under a 2048-byte history release. Both rows
match at the two depths: a page reads the extents of its own commits, not
the history above or below them.

* fix(commits): prove a commit-list continuation for a branch-scoped caller

A commit-list page token is checksummed, not signed, so the commit a
continuation starts at is the caller's claim. A caller allowed to read
main only could re-sign a main token to list a secret branch's commits,
which GET /commits?branch=secret and GET /commits/{id} both refuse it.

Under a policy, a continuation by a caller without the graph-wide read gate
(the gate of GET /commits/{commit_id}) now goes through
list_commits_page_on_branch: the token's commit must be the first commit
below its generation on the branch's first-parent chain from the head, or
the page is refused with 400. That proof walks the chain, so such a
continuation costs what the whole listing costs; a caller with graph-wide
read keeps the page cost. The list_commits_page doc says what the token
does not prove.

Pages through both doors concatenate to the listing on an upgraded root,
whose converted commits carry pre-upgrade ids.

* fix(commits): check a scoped commit-list continuation cheaply, through a read check

list_commits_page_on_branch becomes list_commits_page_readable, which takes
the same ReadCheck as diff_page_readable. A continuation's commit is on the
branch's history when the branch's __manifest holds it (its head or buffer),
when a branch the caller may read published it, or else when a walk down
the branch's first-parent chain finds it. So a branch-scoped caller paging
its own branch no longer walks the history on every page; only a commit
neither cheap rule covers costs the walk. The page is read once and the
check uses its first commit. An unknown commit is refused exactly as an
unreadable one is.

A missing commit met inside the walk is an integrity error, not a 404.
The server shares one read decision between the diff and commit-list
doors. The API documents that a continuation's head_commit_id is the one
its token carries, and openapi.json describes the scoped caller's cost.

* feat(release): publish an edge container image from each edge build (ModernRelay#1060)

* feat(release): publish an edge container image from each edge build

The daily edge run now also publishes a container image of the same build.
It packages the published build release's Linux x86_64 archive, checked
against its checksum and its attestation for this workflow and commit, on
Debian trixie, since the Ubuntu-built archives need glibc 2.39 or newer. The
root Dockerfile takes its base as BASE_IMAGE, bookworm by default, so the
stable image is unchanged.

The image is tagged edge-<commit date>-<short commit> on GHCR and Docker Hub,
checked inside the image for its commit and channel, attested on both
registries, and tagged edge only when the rolling edge release moved. It
never moves latest, and a rerun reuses the image first pushed for the build.

* fix(release): match the image's server features and follow edge as it is now

- Build every release archive with the server's aws feature, as the stable
  image already is, so the edge image packaged from the Linux archive accepts
  OMNIGRAPH_SERVER_BEARER_TOKENS_AWS_SECRET like the image it replaces. Lance's
  S3 support already builds the AWS SDK base; the feature adds one crate. The
  gate checker requires both release builds to enable it.
- Move the edge image tags, and check the edge installer channel, only while
  the rolling edge release still names this build, so a rerun of an older
  run's failed job cannot move them behind a newer build.

* fix(release): skip an edge build whose workflows no longer match main (ModernRelay#1061)

GitHub refuses the workflow token a new tag on a commit whose workflow files
differ from main's current ones ("refusing to allow a GitHub App to create or
update workflow"), and the token can never hold the workflows permission.
An edge build of 02026b5 failed this way after a workflow change merged
during its build. The edge run now checks that the build's workflow files
still match main's before building and again before tagging, and otherwise
publishes nothing, with a notice; the image and installer jobs run only for
a published build.

* fix(release): build the Linux x86_64 archive on a pinned Ubuntu 24.04 runner (ModernRelay#1063)

`ubuntu-latest` moves to Ubuntu 26.04 between 2026-10-19 and 2026-11-19
(actions/runner-images#14748), and a run may land on either image during the
rollout. A Linux archive needs the glibc it was linked against, so the x86_64
archive would start requiring Ubuntu 26.04's glibc, breaking Ubuntu 24.04
and Debian 13 users and the trixie edge image. Pin it to ubuntu-24.04, as the
arm64 archive already is (ubuntu-24.04-arm), document the archives' glibc
2.39 floor, and have the gate checker refuse ubuntu-latest for archive
builds.

* fix(release): pull image bases from Docker Hub when logged in (ModernRelay#1065)

The first edge image build failed twice pulling debian:trixie-slim from ECR
Public: "429 Too Many Requests: Data limit exceeded". GitHub-hosted runners
pull it anonymously from shared addresses, whose data limit is often spent,
and the stable image pulls its bookworm base the same way. Both image
workflows now log in to Docker Hub when the DOCKERHUB_* secrets exist and
build on the Docker Official Image; the stable workflow's rust:1-bookworm
builder pull is then logged in too. Without the secrets, the base still
comes from ECR Public.

* fix(schema): drop a property together with the constraints that name only it (ModernRelay#1062)

A property-level @index, @unique or @key is also stored as a type-level
constraint naming the property by stable id. Dropping the property made
the planner see that constraint disappear and refuse the whole change,
because the constraint comparison did not know which properties the
plan drops. An indexed property could therefore never be removed.

The property planner now returns the stable ids of the properties it
drops, and the constraint comparison no longer refuses a removed
constraint when every field it names is one of them. A @key, a
constraint that also names a field that stays (a remaining property or
@src/@dst), and a constraint removed from a property that stays are
still refused. Apply needs no change: the drop's Operation::Project
already removes the index on the dropped column, and the evolved table
declares full-text analyzers from the desired catalog.

ConstraintIR::fields replaces two copies of the same match in
schema_ir.rs and serves the new rule.

Fixes ModernRelay#1014

* feat(query)!: refuse full-text calls without a full-text index (ModernRelay#1066)

* query: refuse full-text calls without a full-text index (T27, FullTextIndexRequired)

A full-text call (`search`, `fuzzy`, `match_text`, `bm25`) reads its
property's full-text index, whose analyzer folds case and stems; without
one Lance scans with a bare, case-sensitive tokenizer, so the same call
answered differently on an indexed and an unindexed property.

- T27 at type checking: a full-text call on a String node property with no
  one-column full-text `@index`/`@key` is refused, from the schema alone.
  `PropType::index_kind` moves to the compiler and index maintenance uses
  it, so the type checker and the index builder cannot drift. An enum's fix
  points at `=`; a non-String field keeps its operand error.
- FullTextIndexRequired at planning (HTTP 409, `full_text_index_required`
  in the error body): the planner reads the coverage of every property a
  full-text call names, filters included, and refuses `absent`. An
  untrained segment, which every write now declares, is `partial` and
  answers; a table with no fragment, or a type the snapshot does not hold,
  counts as covered. Acceptance refuses a plan that records no coverage,
  or `absent`, for a call, and replay re-derives every recorded coverage
  from the pinned dataset.

Regressions: cases/v2/issue_747_full_text_calls_need_a_full_text_index.gqt
and search.rs::a_full_text_index_with_no_segment_refuses_the_call_issue_747,
both red with their check removed.

* docs: rescope RFC 0047 step 3 and document the full-text index requirement

RFC 0047 records step 3 as refusing only an index with no segment, now
that every write declares a declared column's analyzer, with a
decision-log entry, and its rollout table records steps 2 and 2a as
merged. The search guide, troubleshooting page and execution guide
describe T27 and the 409; the release notes call T27 breaking and tell
operators to validate stored queries before upgrading.

* feat(query): the ranked binding roots its component (ModernRelay#1069)

* feat(query): the ranked binding roots its component

A nearest(), bm25() or rrf() order on a binding a traversal reaches was
refused at planning unless that binding was declared first, and a ranked
binding no declaration introduced could not be ranked at all.

Lowering now roots the top-level component holding the bindings the
leading order key ranks at that binding; a ranked binding only a
traversal introduces gets a NodeScan of its checked type, and every
other binding of the component is reached by a forward or reverse
expand. An rrf() whose arms rank two bindings one traversal connects is
the type error T59. The planner codes P001 and P005 are withdrawn; the
planner keeps both checks as internal errors.

* docs(search): rank a traversal-reached binding

* test(cleanup): qualify scoped retries and keep setup pending until a crash

---------

Co-authored-by: Azim Afroozeh <13484327+azimafroozeh@users.noreply.github.com>
Co-authored-by: Andrew Altshuler <andrew@modernrelay.com>
Co-authored-by: aaltshuler <andrew@collectivelab.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant