Repository navigation
refactor(cli): make scope resolution pure - #1038
Closed
aaltshuler wants to merge 1 commit into
Closed
aaltshuler wants to merge 1 commit into
aaltshuler wants to merge 1 commit into
Conversation
This was referenced Oct 17, 2026
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope selection currently reads
OMNIGRAPH_PROFILEinside the decision function, so identical explicit inputs can resolve differently depending on process state. Makescope::resolve_scopepure over the supplied configuration, flags, capability and ambient profile. Keep a thinresolve_scope_from_envwrapper at the six existing production call sites.Preserve current precedence, refusal text, missing/empty/non-Unicode environment handling, and the distinction between an empty ambient profile and an explicitly empty profile name. Configuration loading, credentials, discovery and managed-context ambiguity checks keep their existing owners and order. No CLI syntax, dependencies or GQT changes.
This is the second refactor slice discussed in #675. It is based directly on main and can be reviewed independently of #1037.
Validation:
OMNIGRAPH_PROFILE, proving the pure tests use only supplied values.--all-targets --locked, warnings denied), formatting, documentation/link checks, spelling andgit diff --checkpass.