Repository navigation
refactor(cli): isolate history execution and delivery - #1042
Closed
aaltshuler wants to merge 11 commits into
Closed
aaltshuler wants to merge 11 commits into
aaltshuler wants to merge 11 commits into
Conversation
5 tasks done
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
History commands previously executed inside the application dispatcher and wrote directly to process output. Move
branch,commit,diff,changes, andsnapshotinto one command family with typed pagination/filter selections and fallible injected output. Preserve command grammar, addressing, managed commit reads, and successful human/JSON output.Dedicated
commit publishandcommit dropnow retain the same conservative write-outcome evidence as theirmutateforms. Losing a response or failing to deliver output must not imply that a completed write can be replayed. History streams flush each page before fetching another; baseline capture holds its output-file lock through durable installation and cursor flush. Application completion also detects failed stderr flushes.Backing issue / RFC
Checklist
Local verification
cargo test -p omnigraph-cli --locked— 507 passed, 19 ignored.cargo test -p omnigraph-cli --locked— 512 passed, 19 ignored, including the real server/fault proxy. Used the shared target directory andCARGO_BIN_EXE_omnigraph-serverpointing to the built server.cargo clippy -p omnigraph-cli --all-targets --locked -- -D warnings -W clippy::dbg_macro— passed.cargo fmt --all --check,git diff --check,python scripts/check-docs.py,bash scripts/check-agents-md.sh, andtypos— passed (docs checker used the repository documentation environment).CLI tests own transport, output and failure evidence; no query semantics changed, so no duplicate GQT cases were added. Full workspace/GQT/cloud qualification remains with CI. Environment-gated cloud and predecessor-binary cases were not independently qualified locally.
Notes for reviewers
This branch is based on #1041 at
93340aa4; while predecessors remain open, the base-to-head diff also includes those earlier slices. The new extraction, outcome fix and documentation are separate commits after that point.The new lost-delivery test proves publish/drop effects against the real server and counts exactly one write request. An empty 204 drop response cannot be body-truncated, so its matrix covers disconnect, proxy 504 and caller abandonment. No new public flags, dependencies, automatic retries, or target resolver were introduced.