Repository navigation
Conversation
…record, with Lance fences RFC 0067 replaces the recovery sidecars with detached table commits, publication of (target, staged, uuid) pins and promotion by transaction replay; RFC 0068 is its sequel, one immutable commit record per graph commit. Both are drafts with their probe, prototype, S3, cross-process and failure-matrix evidence recorded; the prototype itself lives on the spike/rfc-0066-detached-prototype branch and is never merged. The four substrate behaviours the design depends on become lance_surface_guards fences: a stale linear commit rebases over a moved HEAD at zero retries, a detached commit is private and chains, replay lands an identical twin, and a replay over its own twin is refused only for self-conflicting transaction kinds.
This was referenced Sep 16, 2026
Closed
Contributor
Author
|
Consolidated into #744, which carries this stack's complete history merged with current main and revalidated as one tree. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
(target, staged, uuid)pins in one CAS as today, and promotion replays the recorded transaction linearly. No recovery sidecar, no restore compensation, no HEAD-equals-pin invariant. Evidence in the RFC: 14 Lance probes (7 rerun on Lance 12.0.0-rc.1), an engine prototype for mutation, load, merge, ensure-indices and Optimize, S3 runs on RustFS, process kills, two-process races, an old-binary check, manifest-byte measurements, and a 312-cell failure-window matrix.__manifestfold with one immutable record per graph commit; includes the change-set idea for the feed and merge.lance_surface_guards.rsfor the four Lance behaviours RFC 0067 depends on, including the self-conflict rule that decides which transaction kinds may be staged detached (Update, Delete, Rewrite, CreateIndex conflict with their twin; Append, ReserveFragments and delete-only UpdateConfig rebase).No engine behaviour changes. The prototype is on
spike/rfc-0066-detached-prototypefor reference and is not for merge.Checks
cargo test -p omnigraph-engine --test lance_surface_guards(42 passed, 1 ignored)cargo clippy -p omnigraph-engine --all-targets -- -D warnings -W clippy::dbg_macrocargo fmt --all --check,scripts/check-docs.py,typos,scripts/check-agents-md.sh,scripts/check-workflow-action-pins.py