Repository navigation
fix(server): end the MCP write wait before common client timeouts - #999
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #994 from the review of the RFC 0003 amendment (#992, issue #991).
outcome_unknownenvelope. The write itself still runs to completion under the owned-write boundary. A unit test pinsWRITE_DEADLINEbelow that client default.outcome_unknownmessage and the MCP guide now say that a missing response (client timeout, cancellation, dropped connection) is also an unknown outcome. They name the reconcile step: read the target and comparegraph_commit_id, orcommits_list, then replay amutatewithif_graph_commit, so a write that did land fails with 412.graphswith a non-identity credential. The instructions and guide say this needs agraph_listpermit, which a server without a cluster policy refuses (403), and that the other tools still work with a graph id the user supplies.changelog.dchangednote.No route, OpenAPI or policy change.
Checks (local,
CARGO_INCREMENTAL=0,RUST_MIN_STACK=16777216)cargo test -p omnigraph-server --locked: lib 204 passed (2 ignored);boot_settings40 passed (1 ignored);integration263 passed;multi_graph8 passed.cargo clippy -p omnigraph-server --all-targets --locked -- -D warnings -W clippy::dbg_macro: clean.cargo fmt --all --check: clean.check-docs.py,typos: clean.