test: improve coverage for utility classes#351
Conversation
Co-authored-by: RoiSoleil <3462260+RoiSoleil@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Co-authored-by: RoiSoleil <3462260+RoiSoleil@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #351 +/- ##
============================================
+ Coverage 79.68% 79.73% +0.04%
- Complexity 4041 4048 +7
============================================
Files 511 511
Lines 17282 17292 +10
Branches 1339 1339
============================================
+ Hits 13772 13788 +16
+ Misses 2943 2937 -6
Partials 567 567 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Improved branch coverage in
WordTokenizerby adding a test for the null and empty string paths.Improved branch coverage in
FeatureDetectorby adding a test for thebundleContext == nullpath ingetBundle(viagetTestNgPluginVersion).Tested classes:
org.moreunit.util.WordTokenizerorg.moreunit.util.FeatureDetectorNewly covered branches:
WordTokenizer:if(string == null || string.length() == 0)FeatureDetector:if(bundleContext == null)ingetBundle()Edge cases added:
WordTokenizerwithnulland empty string arguments.FeatureDetectorexplicitly passing anullBundleContext.Rationale for mocking choices:
BundleContextdoes not need to be deeply stubbed; passingnullexercises the safe-fallback path within the class. Used standardassertNull()andassertFalse()for these scenarios.try-finallyblock when overriding static state inFeatureDetectorto prevent test pollution.PR created automatically by Jules for task 5861206656196680215 started by @RoiSoleil