Skip to content

Improve modal focus, scroll locking, and Last.fm chart diagnostics - #52

Merged
MosesXD merged 3 commits into
mainfrom
fix/modal-scroll-lock-and-chart-errors
Nov 9, 2026
Merged

MosesXD merged 3 commits into
mainfrom
fix/modal-scroll-lock-and-chart-errors

Conversation

@MosesXD

@MosesXD MosesXD commented Nov 9, 2026

Copy link
Copy Markdown
Owner

Summary

  • Centre and constrain native dialog prompts consistently across the site.
  • Lock the document behind an open modal while preserving and restoring the visitor's scroll position.
  • Keep long dialog content scrollable inside the prompt, including on mobile.
  • Make the Last.fm charts distinguish an empty date range from an API/configuration failure and show provider error details when available.

Scope

  • Shared modal behavior applies to existing native dialogs, including Spotify confirmation, WiPay QR, and Last.fm charts.
  • Does not change the intended rolling 7-day and calendar-month Last.fm history windows.

Verification

  • Requires CI checks and browser testing on desktop and mobile, including opening/closing multiple dialogs and scrolling within a long dialog.
  • Live Last.fm API credentials and deployment configuration still need to be verified separately.

@vercel

vercel Bot commented Nov 9, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
mosesxd.github.io Ready Ready Preview Nov 9, 2026 8:36pm UTC

@vercel

vercel Bot commented Nov 9, 2026

Copy link
Copy Markdown

Deployment failed for project mosesxd.github.io with the following error:

Resource is limited - try again in 24 hours (more than 100, code: "api-deployments-free-per-day").

Learn More: https://vercel.com/mosesxd?upgradeToPro=build-rate-limit

@MosesXD
MosesXD merged commit ad769ff into main Nov 9, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant