Skip to content

🧹 [Lint] Clean up unused fields, discard futures and l10n imports - #317

Draft
NITISH-R-G wants to merge 2 commits into
mainfrom
fix-lint-warnings-6302019199447229906
Draft

🧹 [Lint] Clean up unused fields, discard futures and l10n imports#317
NITISH-R-G wants to merge 2 commits into
mainfrom
fix-lint-warnings-6302019199447229906

Conversation

@NITISH-R-G

@NITISH-R-G NITISH-R-G commented Aug 16, 2026

Copy link
Copy Markdown
Owner

🎯 What:

  • Fixed unused_field lints in webrtc_voice_call_service.dart and family_circle_service.dart.
  • Fixed unused_import lints in generated localization files by excluding lib/l10n/** in analysis_options.yaml and adding header: "" to l10n.yaml.
  • Replaced // ignore: discarded_futures with unawaited from dart:async in first_aid_screen.dart.

💡 Why:
To enforce production-grade standards and eliminate suppressed lints/warnings. Global and file-level suppression should be minimized.

Verification:
Ran dart analyze and flutter test, all passing.

Result:
Cleaner code with proper warning resolutions instead of suppression.


PR created automatically by Jules for task 6302019199447229906 started by @NITISH-R-G

Summary by Sourcery

Clean up lint violations by removing unused fields, updating localization configuration, and replacing suppressed discarded futures with explicit unawaited calls.

Bug Fixes:

  • Resolve unused_field lints in WebRTC voice call and family circle services by dropping unused Ref state.
  • Eliminate discarded_futures lint in the first aid screen by wrapping the background future in unawaited.
  • Remove unused_import suppressions in generated localization files by adjusting l10n configuration and analyzer exclusions.

Enhancements:

  • Simplify service constructors that no longer rely on Ref while preserving their external call-site contract.

Build:

  • Exclude generated localization sources under lib/l10n/** from static analysis to avoid spurious lint noise.

Chores:

  • Update l10n.yaml with an empty header to prevent generation of unused import suppression comments in localization files.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@github-actions

Copy link
Copy Markdown
Contributor

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

@sourcery-ai

sourcery-ai Bot commented Aug 16, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR removes unused fields and imports, replaces a suppressed discarded-futures warning with proper handling via unawaited, and updates analyzer/l10n configuration to avoid future lints in generated localization code.

File-Level Changes

Change Details Files
Clean up unused Ref field usage in state notifier services while keeping constructor contracts stable.
  • Update WebRtcVoiceCallService constructor to take Ref directly without storing it in a private field
  • Remove unused _ref field and its lint suppression from WebRtcVoiceCallService
  • Remove assignment to a nullable Ref field and the field itself from FamilyCircleService, keeping the constructor parameter for future use
lib/services/webrtc_voice_call_service.dart
lib/services/family_circle_service.dart
Replace discarded future suppression with explicit unawaited call for a fire-and-forget operation.
  • Wrap FirstAidStore.getVerifiedAdvice(query) in unawaited to signal intentional non-awaiting
  • Ensure dart:async is available for unawaited usage if not already imported
lib/ui/first_aid_screen.dart
Adjust analyzer and localization configuration to exclude generated l10n files from linting and remove per-file unused_import suppressions.
  • Configure analyzer to exclude lib/l10n/** from analysis to avoid lints on generated localization files
  • Add an empty header configuration in l10n.yaml to control the generated file header
  • Remove unused_import ignore comments from each generated app_localizations_*.dart file to rely on configuration instead of in-file suppression
analysis_options.yaml
l10n.yaml
lib/l10n/app_localizations_bn.dart
lib/l10n/app_localizations_en.dart
lib/l10n/app_localizations_hi.dart
lib/l10n/app_localizations_mr.dart
lib/l10n/app_localizations_ta.dart
lib/l10n/app_localizations_te.dart

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 5484104f-2364-4fdd-96fd-16f5a6c151ea

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@github-actions

Copy link
Copy Markdown
Contributor

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant