Skip to content

🧹 Fix lints and correctly structure analysis options - #319

Draft
NITISH-R-G wants to merge 2 commits into
mainfrom
🧹-fix-lints-analysis-options-1897224534238149125

Hidden character warning

The head ref may contain hidden characters: "\ud83e\uddf9-fix-lints-analysis-options-1897224534238149125"
Draft

🧹 Fix lints and correctly structure analysis options#319
NITISH-R-G wants to merge 2 commits into
mainfrom
🧹-fix-lints-analysis-options-1897224534238149125

Conversation

@NITISH-R-G

@NITISH-R-G NITISH-R-G commented Aug 17, 2026

Copy link
Copy Markdown
Owner

🎯 What:

  • Fixed discarded_futures warning in first_aid_screen.dart by wrapping the Future in unawaited().
  • Fixed unused_field warnings in family_circle_service.dart and webrtc_voice_call_service.dart by removing the unused private class variables while preserving constructor parameters for architectural consistency.
  • Configured analysis_options.yaml to exclude generated l10n files from analysis instead of polluting files with // ignore: unused_import.

💡 Why:

  • To improve code health and strictly adhere to Flutter/Dart production standards by correctly resolving warnings without globally ignoring them or using inline ignores where possible.
  • Generating inline ignores in app_localizations.dart was brittle, thus excluding it directly via the analyzer block is preferred.

Verification:

  • Ran flutter analyze ensuring 0 issues.
  • Ran flutter test confirming all tests pass.

Result:
Cleaner code free of structural and linting warnings, ready for further features and testing.


PR created automatically by Jules for task 1897224534238149125 started by @NITISH-R-G

Summary by Sourcery

Clean up analyzer warnings and generated localization handling while improving CI workflow compatibility.

Bug Fixes:

  • Resolve discarded-future and unused-field analyzer warnings without inline suppression comments.

Enhancements:

  • Structure analyzer configuration to exclude generated localization files and keep generated sources free of lint suppression directives.

CI:

  • Adjust the health dashboard workflow environment configuration for pull request runs.

Chores:

  • Update localization generation settings to omit generated file headers.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 8e542100-dfe6-4757-ae61-9a4574745f99

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

@sourcery-ai

sourcery-ai Bot commented Aug 17, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Cleans up Dart/Flutter lint warnings by properly handling a discarded Future, removing unused private fields while keeping constructor signatures stable, and restructuring analysis options to ignore generated l10n files instead of relying on inline ignores.

File-Level Changes

Change Details Files
Handle previously discarded future in first aid screen without suppressing lint.
  • Wrap FirstAidStore.getVerifiedAdvice(query) in unawaited(...) to acknowledge intentional fire-and-forget behavior.
  • Remove the inline // ignore: discarded_futures comment now that the lint is satisfied by design.
lib/ui/first_aid_screen.dart
Remove unused Ref fields from services while keeping constructors stable for future use.
  • Update WebRtcVoiceCallService constructor to accept Ref ref without storing it in a private field, eliminating the unused_field lint.
  • Remove the _ref assignment and backing field from FamilyCircleService while keeping the Ref? parameter in the constructor for future extensibility.
  • Drop now-unnecessary // ignore: unused_field comments associated with these fields.
lib/services/webrtc_voice_call_service.dart
lib/services/family_circle_service.dart
Replace inline ignore comments in generated localization files with centralized analyzer configuration.
  • Configure analysis_options.yaml to exclude lib/l10n/** from static analysis, treating them as generated files.
  • Remove // ignore: unused_import from each app_localizations_*.dart file so generated code is cleaner.
  • Set header: "" in l10n.yaml to avoid adding extra header comments in generated localization files.
analysis_options.yaml
lib/l10n/app_localizations_bn.dart
lib/l10n/app_localizations_en.dart
lib/l10n/app_localizations_hi.dart
lib/l10n/app_localizations_mr.dart
lib/l10n/app_localizations_ta.dart
lib/l10n/app_localizations_te.dart
l10n.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

…e health fixes

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@github-actions

Copy link
Copy Markdown
Contributor

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant