Skip to content

⚡ Bolt: [performance improvement] Replace ListView + nested Column with CustomScrollView in SosActivityLogScreen - #320

Draft
NITISH-R-G wants to merge 2 commits into
mainfrom
bolt-optimize-sos-activity-log-14332272121793543736
Draft

⚡ Bolt: [performance improvement] Replace ListView + nested Column with CustomScrollView in SosActivityLogScreen#320
NITISH-R-G wants to merge 2 commits into
mainfrom
bolt-optimize-sos-activity-log-14332272121793543736

Conversation

@NITISH-R-G

@NITISH-R-G NITISH-R-G commented Aug 17, 2026

Copy link
Copy Markdown
Owner

💡 What: Replaced ListView and nested Column with CustomScrollView and SliverList.builder in SosActivityLogScreen.
🎯 Why: Rendering a potentially unbounded dynamic list inside a Column nested within a ListView defeats list virtualization, causing all items to be built simultaneously.
📊 Impact: Enables O(1) list virtualization for history items instead of O(n) total item rendering, preventing memory bloat and lagging on devices with long SOS activity histories.
🔬 Measurement: Verify by opening the Activity Log screen with many saved incidents; observe that only visible items are rendered and memory usage stays constant while scrolling.


PR created automatically by Jules for task 14332272121793543736 started by @NITISH-R-G

Summary by Sourcery

Improve SOS activity log scalability and make dashboard workflow environments pull-request safe.

Enhancements:

  • Optimize the SOS activity log for large incident histories by virtualizing saved incident rendering with slivers while preserving current session, loading, empty, and error states.

CI:

  • Adjust the health dashboard workflow’s GitHub Pages environment configuration to avoid assigning the deployment environment for pull requests.

…ActivityLogScreen to enable list virtualization

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 77e25b85-1148-425d-8c07-88b1a34697b0

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

@sourcery-ai

sourcery-ai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Reviewer's Guide

Refactors SosActivityLogScreen’s body from a ListView with an embedded Column into a CustomScrollView composed of slivers, enabling proper list virtualization for the SOS history while preserving existing UI/UX behavior for headers, empty/loaded/error states, and loading spinners.

Flow diagram for history.when states mapped to sliver widgets

flowchart TD
  A[history.when] --> B[data items]
  A --> C[loading]
  A --> D[error e]

  B --> E{items.isEmpty}
  E -->|true| F[SliverToBoxAdapter with Text emptyMessage]
  E -->|false| G[SliverList.builder itemCount items.length]

  C --> H[SliverToBoxAdapter with Center CircularProgressIndicator]
  D --> I[SliverToBoxAdapter with Text errorMessage]
Loading

File-Level Changes

Change Details Files
Replace ListView + Column layout with CustomScrollView + Sliver-based layout to virtualize the SOS history list.
  • Wrap the screen body in a CustomScrollView instead of a ListView to support sliver-based scrolling.
  • Move the static top content (insurance banner, current session section, and saved incidents header) into a SliverPadding containing a SliverList.list of children.
  • Convert the history.when(...) builder to return sliver widgets: SliverToBoxAdapter for empty, loading, and error states, and SliverList.builder for the populated history list.
  • Adjust padding so the top and bottom sections use separate SliverPadding instances to match previous ListView padding behavior.
  • Preserve existing text styles, spacing, and widgets (DispatchStatusPanel, section titles, etc.) while restructuring them into slivers.
lib/ui/sos_activity_log_screen.dart

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@github-actions

Copy link
Copy Markdown
Contributor

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant