Skip to content

🧹 Clean up ignore comments and resolve lints - #322

Draft
NITISH-R-G wants to merge 1 commit into
mainfrom
lint-cleanup-13074930513025224827
Draft

🧹 Clean up ignore comments and resolve lints#322
NITISH-R-G wants to merge 1 commit into
mainfrom
lint-cleanup-13074930513025224827

Conversation

@NITISH-R-G

@NITISH-R-G NITISH-R-G commented Aug 18, 2026

Copy link
Copy Markdown
Owner

🎯 What: Removed unused fields (_ref in WebRtcVoiceCallService and FamilyCircleService), suppressed third-party lints globally (experimental_member_use), fixed discarded futures properly using unawaited(), and removed all // ignore: and // ignore_for_file: comments.
💡 Why: To improve code health and remove bad code suppression patterns, enforcing strict linting without bypassing rules in source files.
Verification: dart analyze and flutter test both passed.
Result: Cleaned up code health and improved compliance with strict repository standards.


PR created automatically by Jules for task 13074930513025224827 started by @NITISH-R-G

Summary by Sourcery

Clean up lint suppression and unused code while centralizing necessary analyzer configuration.

Enhancements:

  • Remove unused service fields and replace discarded-future suppression with explicit unawaited handling.
  • Eliminate inline lint-ignore directives while preserving required generated localization and experimental API lint behavior through project configuration.

Build:

  • Configure localization generation to omit generated file headers.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: b290579e-7d2f-4501-9647-be7db0545ba8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

@sourcery-ai

sourcery-ai Bot commented Aug 18, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR tightens linting discipline by moving third‑party and generated-code exceptions into global configuration, removing local ignore comments and unused fields, and fixing a discarded future by explicitly marking it unawaited.

File-Level Changes

Change Details Files
Centralize lint configuration and exclude generated localization code from analysis.
  • Configured the analyzer to ignore experimental_member_use errors globally instead of via file-level ignores.
  • Excluded lib/l10n/** from analyzer processing to avoid enforcing lints on generated localization files.
  • Kept existing lints from flutter_lints while layering project-specific analyzer settings.
analysis_options.yaml
Remove unused Ref fields from services while keeping constructor contracts stable.
  • Updated WebRtcVoiceCallService to take a Ref parameter without storing it, eliminating the unused _ref field and its ignore comment.
  • Stopped storing Ref in FamilyCircleService and removed the unused _ref field and its ignore comment while preserving the constructor signature and bootstrap behavior.
lib/services/webrtc_voice_call_service.dart
lib/services/family_circle_service.dart
Handle discarded futures explicitly using unawaited for best-effort async calls.
  • Replaced an ignore: discarded_futures comment with a call to unawaited() around FirstAidStore.getVerifiedAdvice, making the intentional fire-and-forget behavior explicit.
lib/ui/first_aid_screen.dart
Clean up ignore comments and align localization generation with analyzer configuration.
  • Removed unused_import and type=lint ignore comments from generated app_localizations_* files, relying instead on analyzer exclusion and generation headers.
  • Configured l10n.yaml with an empty header to prevent regeneration of ignore comments in localization output.
  • Removed a file-level ignore_for_file: type=lint from the main app_localizations.dart.
  • Dropped the file-level ignore_for_file: experimental_member_use from emergency_beacon_service.dart since the rule is now globally ignored.
lib/l10n/app_localizations_bn.dart
lib/l10n/app_localizations_en.dart
lib/l10n/app_localizations_hi.dart
lib/l10n/app_localizations_mr.dart
lib/l10n/app_localizations_ta.dart
lib/l10n/app_localizations_te.dart
lib/l10n/app_localizations.dart
l10n.yaml
lib/services/emergency_beacon_service.dart

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant