Skip to content

🧹 [Code Quality] Fix linter warnings and clean up ignores - #323

Draft
NITISH-R-G wants to merge 1 commit into
mainfrom
fix-linter-warnings-16998877128235154969
Draft

🧹 [Code Quality] Fix linter warnings and clean up ignores#323
NITISH-R-G wants to merge 1 commit into
mainfrom
fix-linter-warnings-16998877128235154969

Conversation

@NITISH-R-G

@NITISH-R-G NITISH-R-G commented Aug 19, 2026

Copy link
Copy Markdown
Owner

🎯 What:

  • Fixed unused_field warnings in WebRtcVoiceCallService and FamilyCircleService by removing the unused private _ref fields while retaining the Ref ref parameter in the constructors to preserve the call-site contracts.
  • Fixed discarded_futures warning in FirstAidScreen by replacing the // ignore comment with unawaited() from dart:async.
  • Fixed experimental_member_use warning in EmergencyBeaconService by removing the local // ignore_for_file and globally suppressing it in analysis_options.yaml (since it stems from a third-party package).
  • Fixed l10n code generation warnings by adding header: "" to l10n.yaml to prevent automatic // ignore generation, removing existing ignores, and excluding lib/l10n/** from static analysis.

💡 Why:

  • To adhere to production standards that forbid suppressing linting warnings via // ignore or // ignore_for_file comments in source code, ensuring all warnings are resolved architecturally or managed globally when necessary.
  • To improve code quality and maintainability.

Verification:

  • Ran dart analyze and confirmed no issues found.
  • Ran flutter test and confirmed all tests passed.
  • Restored pubspec.lock to prevent CI regression.

Result:

  • A cleaner, warning-free codebase without inline lint suppressions.

PR created automatically by Jules for task 16998877128235154969 started by @NITISH-R-G

Summary by Sourcery

Eliminate inline lint suppressions and configure analysis and localization generation for a cleaner warning-free codebase.

Bug Fixes:

  • Resolve lint warnings for unused constructor fields and discarded futures without inline suppression comments.

Enhancements:

  • Clean up generated localization files and remove source-level lint ignores while preserving required analyzer configuration for generated code and third-party experimental APIs.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@github-actions

Copy link
Copy Markdown
Contributor

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 6d9bf180-06e0-4205-9ee1-be8d4fc2436d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sourcery-ai

sourcery-ai Bot commented Aug 19, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR removes inline lint suppressions and fixes the underlying issues or manages them via analyzer configuration, focusing on unused fields, discarded futures, experimental member use, and l10n codegen warnings.

Sequence diagram for FirstAidScreen side-channel unawaited call

sequenceDiagram
  actor User
  participant FirstAidScreenState
  participant FirstAidStore

  User->>FirstAidScreenState: [enter query]
  FirstAidScreenState->>FirstAidScreenState: setState(update _result)
  FirstAidScreenState->>FirstAidStore: getVerifiedAdvice(query)
  activate FirstAidStore
  Note over FirstAidScreenState,FirstAidStore: call wrapped with unawaited for best-effort side-channel
  deactivate FirstAidStore
Loading

File-Level Changes

Change Details Files
Resolve unused Ref fields in state notifier services without changing constructor call-site contracts.
  • Change WebRtcVoiceCallService constructor to accept Ref directly and drop the unused private field.
  • Remove the unused nullable Ref field from FamilyCircleService while keeping the Ref parameter for future use.
  • Ensure bootstrap logic remains intact after field removals.
lib/services/webrtc_voice_call_service.dart
lib/services/family_circle_service.dart
Handle discarded futures in FirstAidScreen via unawaited rather than inline ignore comments.
  • Wrap FirstAidStore.getVerifiedAdvice(query) in unawaited() to explicitly mark it as fire-and-forget.
  • Remove the discarded_futures ignore comment.
lib/ui/first_aid_screen.dart
Move experimental_member_use suppression from a local ignore to analyzer-level configuration.
  • Delete // ignore_for_file: experimental_member_use from EmergencyBeaconService.
  • Configure analyzer.errors.experimental_member_use: ignore in analysis_options.yaml.
lib/services/emergency_beacon_service.dart
analysis_options.yaml
Clean up l10n-generated files and prevent future inline ignore generation while excluding them from analysis.
  • Remove unused_import and type=lint ignore_for_file comments from all generated app_localizations*.dart files.
  • Add header: "" to l10n.yaml to stop auto-generation of ignore headers.
  • Configure analyzer to exclude lib/l10n/** from static analysis.
lib/l10n/app_localizations_bn.dart
lib/l10n/app_localizations_en.dart
lib/l10n/app_localizations_hi.dart
lib/l10n/app_localizations_mr.dart
lib/l10n/app_localizations_ta.dart
lib/l10n/app_localizations_te.dart
lib/l10n/app_localizations.dart
l10n.yaml
analysis_options.yaml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant