Skip to content

⚡ Bolt: [performance improvement] Optimize SOS activity log rendering - #324

Draft
NITISH-R-G wants to merge 2 commits into
mainfrom
bolt-optimize-sos-log-18324159394879695819
Draft

⚡ Bolt: [performance improvement] Optimize SOS activity log rendering#324
NITISH-R-G wants to merge 2 commits into
mainfrom
bolt-optimize-sos-log-18324159394879695819

Conversation

@NITISH-R-G

@NITISH-R-G NITISH-R-G commented Aug 20, 2026

Copy link
Copy Markdown
Owner

💡 What: Replaced ListView and Column mapping with CustomScrollView and SliverList.builder inside lib/ui/sos_activity_log_screen.dart.
🎯 Why: The previous implementation embedded a dynamic list of history items mapped to widgets directly inside a Column wrapped in a ListView. This defeated list virtualization and forced all elements to be synchronously built at layout time (O(n) rendering cost), potentially blocking the main thread when dealing with a large history array.
📊 Impact: Reduces initial rendering latency by virtualizing the list elements to strictly what is visible on the screen, lowering memory overhead and enabling O(1) rendering costs for list items regardless of history size.
🔬 Measurement: Verify by examining the flutter inspector and observing memory allocation dropping compared to a large unvirtualized array, or verify SliverList metrics in DevTools during scrolling.


PR created automatically by Jules for task 18324159394879695819 started by @NITISH-R-G

Summary by Sourcery

Improve SOS activity log scalability and make dashboard workflow handling safer for pull requests.

Bug Fixes:

  • Prevent GitHub Pages environment configuration from being applied to pull request workflow runs.

Enhancements:

  • Optimize SOS activity history rendering with virtualized sliver-based scrolling to improve performance for large incident lists.

CI:

  • Adjust the health dashboard workflow environment selection for pull request events.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 7011d7a2-eae5-4b45-bb87-1ddaca33e487

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

@sourcery-ai

sourcery-ai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Reviewer's Guide

Refactors the SOS activity log screen to use a sliver-based, virtualized scroll layout instead of a ListView+Column, improving performance and memory usage for large histories while preserving existing UI semantics.

Flow diagram for sliver-based SOS activity log rendering

flowchart TD
  SosActivityLogScreen --> CustomScrollView
  CustomScrollView --> history_when

  history_when -->|data_items| items_nonnull
  history_when -->|loading| sliver_loading
  history_when -->|error_e| sliver_error

  items_nonnull --> items_empty
  items_nonnull --> items_nonempty

  items_empty[items.isEmpty] --> sliver_no_incidents[SliverToBoxAdapter no_incidents_text]

  items_nonempty[items.isNotEmpty] --> sliver_history_list[SliverPadding + SliverList_builder _historyCard]

  sliver_loading[SliverFillRemaining CircularProgressIndicator]

  sliver_error[SliverToBoxAdapter error_text]
Loading

File-Level Changes

Change Details Files
Replace ListView+Column composition with CustomScrollView and sliver-based layout to enable list virtualization for the activity history.
  • Changed the screen body root widget from ListView to CustomScrollView with slivers.
  • Wrapped static header content (insurance banner, current session section, saved incidents title) in SliverPadding + SliverList using SliverChildListDelegate.
  • Converted the mapped Column of history items into a SliverList.builder for on-demand item construction.
lib/ui/sos_activity_log_screen.dart
Adapt empty, loading, and error states to the new sliver-based scroll structure while keeping visual behavior consistent.
  • Wrapped the empty-state message in SliverToBoxAdapter with horizontal padding to match previous layout margins.
  • Replaced the centered loading indicator with SliverFillRemaining so it occupies remaining scroll space within the sliver context.
  • Wrapped the error message in SliverToBoxAdapter with horizontal padding and updated it to fit within the sliver layout.
  • Added a bottom SliverPadding to preserve trailing whitespace at the end of the scroll.
lib/ui/sos_activity_log_screen.dart

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

…nally skips github-pages environment on PRs.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@github-actions

Copy link
Copy Markdown
Contributor

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant