Skip to content

Fix linter warnings - #325

Draft
NITISH-R-G wants to merge 2 commits into
mainfrom
fix-linter-warnings-7488766125870761778
Draft

Fix linter warnings#325
NITISH-R-G wants to merge 2 commits into
mainfrom
fix-linter-warnings-7488766125870761778

Conversation

@NITISH-R-G

@NITISH-R-G NITISH-R-G commented Aug 20, 2026

Copy link
Copy Markdown
Owner

Removed ignore comments and fixed unused fields in services and discarded futures in UI.


PR created automatically by Jules for task 7488766125870761778 started by @NITISH-R-G

Summary by Sourcery

Resolve linter warnings across services, UI, and workflow configuration without changing application behavior.

Enhancements:

  • Remove unused service fields and make the UI’s best-effort advice lookup explicitly non-blocking.
  • Avoid assigning a GitHub Pages deployment environment for pull request workflow runs.

CI:

  • Adjust the health dashboard workflow environment handling for pull request runs.

Chores:

  • Clean up linter warnings by replacing suppressions with compliant code.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 6274342c-704a-4e67-a04e-b306422d4f07

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

@sourcery-ai

sourcery-ai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR fixes linter warnings by removing unused Ref fields from services and properly handling a discarded future in the UI, while preserving existing behavior and constructor contracts as much as possible.

Sequence diagram for unawaited FirstAidStore.getVerifiedAdvice call

sequenceDiagram
  actor User
  participant FirstAidScreenState
  participant FirstAidStore

  User->>FirstAidScreenState: triggerFirstAidQuery(query)
  FirstAidScreenState->>FirstAidStore: unawaited(getVerifiedAdvice(query))
  FirstAidStore-->>FirstAidScreenState: Future<VerifiedAdvice> (ignored)
Loading

File-Level Changes

Change Details Files
Remove unused Ref field from WebRtcVoiceCallService while keeping the service initialization behavior intact.
  • Change WebRtcVoiceCallService constructor to take a Ref parameter without storing it as a field
  • Remove the unused _ref field from WebRtcVoiceCallService
  • Leave _bootstrap call in the constructor to preserve initialization behavior
lib/services/webrtc_voice_call_service.dart
Remove unused Ref field from FamilyCircleService while preserving the public constructor contract and bootstrap behavior.
  • Stop assigning the incoming Ref parameter to a backing field
  • Remove the unused nullable _ref field from FamilyCircleService
  • Keep the explanatory comment that Ref is intentionally unused and retain the _bootstrap call in the constructor
lib/services/family_circle_service.dart
Handle a discarded future in FirstAidScreen using an explicit unawaited wrapper to satisfy linter rules.
  • Wrap the call to FirstAidStore.getVerifiedAdvice(query) in unawaited to mark it as intentionally not awaited
  • Preserve the best-effort side-channel behavior for priming FirstAidStore
lib/ui/first_aid_screen.dart

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your trial has ended. Reactivate Greptile to resume code reviews.

@github-actions

Copy link
Copy Markdown
Contributor

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant